Date: Sun, 23 Nov 2008 20:10:35 +0800 From: Ganbold <ganbold@micom.mng.net> To: Alexander Motin <mav@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r185183 - head/sys/netgraph Message-ID: <4929483B.9070404@micom.mng.net> In-Reply-To: <200811221655.mAMGttpJ023528@svn.freebsd.org> References: <200811221655.mAMGttpJ023528@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Alexander Motin wrote: > Author: mav > Date: Sat Nov 22 16:55:55 2008 > New Revision: 185183 > URL: http://svn.freebsd.org/changeset/base/185183 > > Log: > Remove unused variable. > > Found with: Coverity Prevent(tm) > CID: 3682 > > Modified: > head/sys/netgraph/ng_socket.c > > Modified: head/sys/netgraph/ng_socket.c > ============================================================================== > --- head/sys/netgraph/ng_socket.c Sat Nov 22 16:40:12 2008 (r185182) > +++ head/sys/netgraph/ng_socket.c Sat Nov 22 16:55:55 2008 (r185183) > @@ -259,9 +259,8 @@ ngc_send(struct socket *so, int flags, s > if (msg->header.typecookie == NGM_GENERIC_COOKIE && > msg->header.cmd == NGM_MKPEER) { > struct ngm_mkpeer *const mkp = (struct ngm_mkpeer *) msg->data; > - struct ng_type *type; > > - if ((type = ng_findtype(mkp->type)) == NULL) { > + if (ng_findtype(mkp->type) == NULL) { > char filename[NG_TYPESIZ + 3]; > int fileid; > > @@ -275,7 +274,7 @@ ngc_send(struct socket *so, int flags, s > } > > /* See if type has been loaded successfully. */ > - if ((type = ng_findtype(mkp->type)) == NULL) { > + if (ng_findtype(mkp->type) == NULL) { > free(msg, M_NETGRAPH_MSG); > (void)kern_kldunload(curthread, fileid, > LINKER_UNLOAD_NORMAL); > Thanks, what a coincident :) I have sent exactly same patch to rwatson@ and glebius@ yesterday night :) Ganbold > _______________________________________________ > svn-src-all@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" > > > > -- Old Grandad is dead but his spirits live on.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4929483B.9070404>