Date: Mon, 02 Dec 2002 16:00:17 -0800 From: Peter Wemm <peter@wemm.org> To: Marcel Moolenaar <marcel@xcllnt.net> Cc: Doug Rabson <dfr@nlsystems.com>, Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 21719 for review Message-ID: <20021203000017.A28372A8AB@canning.wemm.org> In-Reply-To: <20021202101553.GB6494@dhcp01.pn.xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Marcel Moolenaar wrote: > On Mon, Dec 02, 2002 at 09:58:30AM +0000, Doug Rabson wrote: > > > > I'm sorry - I thought that the thing was converted to bus_space when it > > grew all the non-isa bus attachments. This really needs to happen to > > make the driver portable. I'm not sure what to do with the > > isa_irq_pending call - probably migrate it to the isa attachment. > > I'm not sure. It really assumes PIC and doesn't really work with > APICs, due to it being a 32-bit bitmask. This is independent of > whether the device is on an ISA bus or not. I guess I don't have > an answer yet. int32 mask = isa_irq_pending() could be replaced with something like: bool pending = irq_pending(int irq); This can then be made to work on apic systems without too much work. But it is still wrong. :-) Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021203000017.A28372A8AB>