Date: Mon, 27 Jan 2003 00:10:15 -0800 From: "David O'Brien" <obrien@freebsd.org> To: Maxim Konovalov <maxim@macomnet.ru> Cc: current@freebsd.org Subject: Re: [PATCH]: newfs(8) FS_OPTSPACE vs FS_OPTTIME bug Message-ID: <20030127081015.GC61926@dragon.nuxi.com> In-Reply-To: <20030123133044.G77851@news1.macomnet.ru> References: <20030123133044.G77851@news1.macomnet.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 23, 2003 at 01:42:58PM +0300, Maxim Konovalov wrote:
> Any objections to a diff below?
We should be moving away from magic numbers to #defined constants, not
the otherway around.
> Index: newfs/newfs.c
> ===================================================================
> RCS file: /home/ncvs/src/sbin/newfs/newfs.c,v
> retrieving revision 1.66
> diff -u -r1.66 newfs.c
> --- newfs/newfs.c 30 Nov 2002 18:28:26 -0000 1.66
> +++ newfs/newfs.c 23 Jan 2003 10:26:45 -0000
> - if (minfree < MINFREE && opt != FS_OPTSPACE) {
> + if (minfree <= 5 && opt != FS_OPTSPACE) {
> - fprintf(stderr, "because minfree is less than %d%%\n", MINFREE);
> + fprintf(stderr, "because minfree is less than %d%%\n", 5);
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030127081015.GC61926>