Date: Fri, 30 Mar 2018 02:20:24 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: rgrimes@freebsd.org Cc: Ian Lepore <ian@freebsd.org>, src-committers@freebsd.org, svn-src-stable@freebsd.org, svn-src-all@freebsd.org, svn-src-stable-11@freebsd.org, Marcelo Araujo <araujo@freebsd.org> Subject: Re: svn commit: r331728 - in stable/11/etc: . rc.d Message-ID: <20180330022024.GA60787@FreeBSD.org> In-Reply-To: <201803291633.w2TGXinX064128@pdx.rh.CN85.dnsmgr.net> References: <1522340373.49673.112.camel@freebsd.org> <201803291633.w2TGXinX064128@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 29, 2018 at 09:33:44AM -0700, Rodney W. Grimes wrote: > ... > It seems that the Phabricator review system is somewhat disfunctional > in that actual review is only happening in some cases. Some people > have even stated they flat out hate it. Others say that it is the > way to go. As imp@ and ian@ had said it does not look too bad in src land, where people use it more or less correctly (putting up disputable changes, seeking review from people with better expertise or domain knowledge, etc.). It's far worse in ports when people often abuse it for trivial changes that should just be committed (and usually they are, without any activity in the Phab expect opening a DR and then closing it). ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180330022024.GA60787>