Date: Thu, 23 Jan 2014 13:45:55 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: "Simon J. Gerraty" <sjg@juniper.net> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>, Brooks Davis <brooks@freebsd.org> Subject: Re: Makefile.inc1.patch Message-ID: <949DAC82-A5AA-42FE-81A5-385A84718166@gmail.com> In-Reply-To: <20140123214335.DD4255807E@chaos.jnpr.net> References: <B4D2A908-715F-484F-8028-A1F38884AF3F@gmail.com> <CAOtMX2jQ24JCR2Ct8YKob4MKcHWMhVVv5XG-1usoPWqEOA2OQg@mail.gmail.com> <4A3E3984-73D3-4441-97A7-D58679EFF978@gmail.com> <9775878D-91AB-4BE4-ADFA-32D8DB582AA6@gmail.com> <CAOtMX2hhW9wrN0b4UCKFRS79ata45c-vczMuHMmWcZTic_FeHw@mail.gmail.com> <DA04C3C3-486D-4784-87E2-33A73545A250@gmail.com> <CAOtMX2g-ChC3_hnk=NE1ZDfWOQp36eeAxcXt3f-ccxyRShz64Q@mail.gmail.com> <4DB8E40F-6D7B-41A9-A0FA-B2E241E9A180@gmail.com> <20140123214335.DD4255807E@chaos.jnpr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jan 23, 2014, at 1:43 PM, Simon J. Gerraty <sjg@juniper.net> wrote: >=20 > On Thu, 23 Jan 2014 13:23:57 -0800, Garrett Cooper writes: >> NO_TESTS forces WITHOUT_TESTS to be set. So, if I set NO_TESTS =3D= >> in the various build steps it will force ATF to not be built. For = that =3D >> reason (and that reason alone) I reintroduced WITH_ATF just for =3D >> Makefile.inc1 (but you could replace it with something else like =3D >> WITH_ATF_LIBS, etc, if the naming is too confusing). >=20 > Is there a need to have a knob at all? To build atf libs I mean. For right now yeah, it=92s distinguished that way :/.. but it = seems lightweight enough (2 mins compile time?) to include in standard = builds. Maybe have a well-documented NO_ATF_LIBS knob for those that = need the extra compile time? Thanks! -Garrett=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?949DAC82-A5AA-42FE-81A5-385A84718166>