Date: Mon, 26 Jan 2026 11:58:18 -0500 From: "Drew Gallatin" <gallatin@freebsd.org> To: =?UTF-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: a11d132f6c62 - main - devstat: Provide 32-bit compatibility Message-ID: <b49495d5-44f4-4bec-b4fd-261d12afcc4e@app.fastmail.com> In-Reply-To: <86jyx4e3ec.fsf@ltc.des.dev> References: <697757ba.b040.558a1a55@gitrepo.freebsd.org> <d5878bcd-b7b7-4acc-9897-7f7041d0643d@app.fastmail.com> <86jyx4e3ec.fsf@ltc.des.dev>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Mon, Jan 26, 2026, at 11:37 AM, Dag-Erling Smørgrav wrote: > "Drew Gallatin" <gallatin@freebsd.org> writes: > > In file included from /usr/src/sys/kern/subr_devstat.c:47: > > In file included from /usr/src/sys/compat/freebsd32/freebsd32.h:38: > > /usr/src/sys/sys/user.h:692:16: error: field has incomplete type 'struct kevent' > > 692 | struct kevent knt_event; > > | ^ > > /usr/src/sys/sys/user.h:692:9: note: forward declaration of 'struct kevent' > > 692 | struct kevent knt_event; > > This is a preexisting bug in <sys/compat/freebsd32/freebsd32.h> which > needs to include <sys/event.h> but doesn't. It is hidden from most > users by header pollution from the VIMAGE option. Thanks for the quick fix. I'm an oddball b/c I cannot stand VIMAGE (makes network stuff incredibly frustrating to debug and adds overhead). > > include GENERIC-NODEBUG > > [...] > > nooptions INVARIANTS > > nooptions INVARIANT_SUPPORT > > nooptions WITNESS > > nooptions WITNESS_SKIPSPIN > > nooptions BUF_TRACKING > > nooptions DEADLKRES > > nooptions FULL_BUF_TRACKING > > nooptions COVERAGE > > nooptions KCOV > > These lines are already included in GENERIC-NODEBUG. Indeed.. Thanks again, Drew [-- Attachment #2 --] <!DOCTYPE html><html><head><title></title></head><body><div><br></div><div><br></div><div>On Mon, Jan 26, 2026, at 11:37 AM, Dag-Erling Smørgrav wrote:</div><blockquote type="cite" id="qt" style=""><div>"Drew Gallatin" <<a href="mailto:gallatin@freebsd.org">gallatin@freebsd.org</a>> writes:</div><div>> In file included from /usr/src/sys/kern/subr_devstat.c:47:</div><div>> In file included from /usr/src/sys/compat/freebsd32/freebsd32.h:38:</div><div>> /usr/src/sys/sys/user.h:692:16: error: field has incomplete type 'struct kevent'</div><div>> 692 | struct kevent knt_event;</div><div>> | ^</div><div>> /usr/src/sys/sys/user.h:692:9: note: forward declaration of 'struct kevent'</div><div>> 692 | struct kevent knt_event;</div><div><br></div><div>This is a preexisting bug in <sys/compat/freebsd32/freebsd32.h> which</div><div>needs to include <sys/event.h> but doesn't. It is hidden from most</div><div>users by header pollution from the VIMAGE option.</div></blockquote><div><br></div><div>Thanks for the quick fix. I'm an oddball b/c I cannot stand VIMAGE (makes network stuff incredibly frustrating to debug and adds overhead).</div><div><br></div><blockquote type="cite" id="qt" style=""><div>> include GENERIC-NODEBUG</div><div>> [...]</div><div>> nooptions INVARIANTS</div><div>> nooptions INVARIANT_SUPPORT</div><div>> nooptions WITNESS</div><div>> nooptions WITNESS_SKIPSPIN</div><div>> nooptions BUF_TRACKING</div><div>> nooptions DEADLKRES</div><div>> nooptions FULL_BUF_TRACKING</div><div>> nooptions COVERAGE</div><div>> nooptions KCOV</div><div><br></div><div>These lines are already included in GENERIC-NODEBUG.</div></blockquote><div><br></div><div>Indeed.. </div><div><br></div><div>Thanks again,</div><div>Drew</div><div><br></div></body></html>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b49495d5-44f4-4bec-b4fd-261d12afcc4e>