Date: Tue, 5 Feb 2013 13:02:26 -0800 From: Jack Vogel <jfvogel@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: freebsd-net@freebsd.org, Robert Watson <rwatson@freebsd.org>, Randall Stewart <rrs@lakerest.net>, Kip Macy <kmacy@freebsd.org> Subject: Re: Driver patch to look at... Message-ID: <CAFOYbcmD==OrmP-b0jwbyX8vYykUE95KJ0hi5mgKjg7WyR1zZQ@mail.gmail.com> In-Reply-To: <201302051552.04275.jhb@freebsd.org> References: <D3AA078A-CD19-4228-A019-BE9C985895E2@lakerest.net> <201302051411.52495.jhb@freebsd.org> <74624C61-0564-420F-9F82-0475488F857C@lakerest.net> <201302051552.04275.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Thanks for being the critical eye John :) And I appreciate the work Randall, thanks! Jack On Tue, Feb 5, 2013 at 12:52 PM, John Baldwin <jhb@freebsd.org> wrote: > On Tuesday, February 05, 2013 2:30:36 pm Randall Stewart wrote: > > Ok > > > > Here it is one last time (I hope) with the updates ;-) > > One more suggestion. I would make the check in buf_ring_putback_sc() a > KASSERT() so that in the production case we don't pay for a branch that > should > never occur. > > -- > John Baldwin >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFOYbcmD==OrmP-b0jwbyX8vYykUE95KJ0hi5mgKjg7WyR1zZQ>