Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 21 Jul 2007 23:42:01 GMT
From:      "Constantine A. Murenin" <cnst@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 123874 for review
Message-ID:  <200707212342.l6LNg1w9045779@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=123874

Change 123874 by cnst@dale on 2007/07/21 23:41:40

	KNF

Affected files ...

.. //depot/projects/soc2007/cnst-sensors/sys.kern/kern_sysctl.c#3 edit

Differences ...

==== //depot/projects/soc2007/cnst-sensors/sys.kern/kern_sysctl.c#3 (text+ko) ====

@@ -156,18 +156,16 @@
 	int error;
 
 	error = ENOENT;
-	if (oidp->oid_number == OID_AUTO) {
+	if (oidp->oid_number == OID_AUTO)
 		error = EINVAL;
-	} else {
-		SLIST_FOREACH(p, oidp->oid_parent, oid_link) {
+	else
+		SLIST_FOREACH(p, oidp->oid_parent, oid_link)
 			if (p == oidp) {
 				SLIST_REMOVE(oidp->oid_parent, oidp,
 				    sysctl_oid, oid_link);
 				error = 0;
 				break;
 			}
-		}
-	}
 
 	/* 
 	 * This can happen when a module fails to register and is



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200707212342.l6LNg1w9045779>