Date: Mon, 6 Apr 2015 14:14:05 -0700 From: Adrian Chadd <adrian@freebsd.org> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: Eric Badger <eric@badgerio.us>, freebsd-current <freebsd-current@freebsd.org> Subject: Re: Early use of log() does not end up in kernel msg buffer Message-ID: <CAJ-Vmo=msh--7sWjQaM2P7bo0o3VyAaba0DfYwCVvHZS05dYmw@mail.gmail.com> In-Reply-To: <70135.1428354681@critter.freebsd.dk> References: <5514CC6D.3020607@badgerio.us> <2033248.Eu3RHS8lTG@ralph.baldwin.cx> <70135.1428354681@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On 6 April 2015 at 14:11, Poul-Henning Kamp <phk@phk.freebsd.dk> wrote:
> --------
> In message <2033248.Eu3RHS8lTG@ralph.baldwin.cx>, John Baldwin writes:
>
>>I think phk@ broke this back in 70239. Before that the log() function did
>>this:
>>
>>log()
>>{
>>
>> /* log to the msg buffer */
>> kvprintf(fmt, msglogchar, ...);
>>
>> if (!log_open) {
>> /* log to console */
>> kvprintf(fmt, putchar, ...);
>> }
>>}
>>
>>I think your patch is fine unless phk@ (cc'd) has a reason for not wanting to
>>do this.
>
> The reason was systems not running syslog having slow serial consoles.
.. and that's still a thing, btw.
-adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmo=msh--7sWjQaM2P7bo0o3VyAaba0DfYwCVvHZS05dYmw>