Date: Thu, 30 Nov 2017 12:16:50 +0000 From: Edward Napierala <trasz@freebsd.org> To: Bruce Evans <brde@optusnet.com.au> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r326314 - in head/sys: ddb kern sys Message-ID: <CAFLM3-q=VLrGmCmz3kWZF_vwz6kf9OKk_=Ketp5JOZDZ%2B_ytgA@mail.gmail.com> In-Reply-To: <20171129030035.W2283@besplex.bde.org> References: <201711281253.vASCrtlB071488@repo.freebsd.org> <20171129030035.W2283@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2017-11-28 17:04 GMT+00:00 Bruce Evans <brde@optusnet.com.au>: > On Tue, 28 Nov 2017, Edward Tomasz Napierala wrote: > > Log: >> Make kdb_reenter() silent when explicitly called from db_error(). >> This removes the useless backtrace on various ddb(4) user errors. >> >> Reviewed by: jhb@ >> Obtained from: CheriBSD >> MFC after: 2 weeks >> Sponsored by: DARPA, AFRL >> Differential Revision: https://reviews.freebsd.org/D13212 >> > > This doesn't fix the spam for user errors that cause a trap, which are > very common (for mistyping memory addresses). ddb sets up trap handlers > using setjmp, and actually does this correctly in many cases, but when > a trap occurs the error handling is: > > trap -> kdb_reenter (print spam here) -> ddb (print error message here) > Indeed. But, as you said later in that email, some of those messages actually are (or might be) useful. The intent of that change was only to silence down those that certainly are not. Also, differently from silencing them down with a sysctl, this change makes them silent out of the box. Agreed about the style problems; I might (can't promise, though) fix that later.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFLM3-q=VLrGmCmz3kWZF_vwz6kf9OKk_=Ketp5JOZDZ%2B_ytgA>