Date: Tue, 25 Nov 2008 16:28:27 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Josh Carroll <josh.carroll@gmail.com> Cc: freebsd-fs@freebsd.org, FreeBSD Stable <freebsd-stable@freebsd.org> Subject: Re: ext2 inode size patch - RE: PR kern/124621 Message-ID: <20081125142827.GI2042@deviant.kiev.zoral.com.ua> In-Reply-To: <8cb6106e0811250617q5fffb41exe20dfb8314fc4a9d@mail.gmail.com> References: <8cb6106e0811241129o642dcf28re4ae177c8ccbaa25@mail.gmail.com> <20081125140601.GH2042@deviant.kiev.zoral.com.ua> <8cb6106e0811250617q5fffb41exe20dfb8314fc4a9d@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--YrQNB5Deg1WGKZi3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 25, 2008 at 09:17:06AM -0500, Josh Carroll wrote: > > I already expressed my opinion on > > http://lists.freebsd.org/pipermail/freebsd-hackers/2008-September/02593= 3.html > > >=20 > Sorry, I do not subscribe to hackers@ so I did not see that message. > So what do you recommend is done to further test it? I tested simple > things like copies, writes, deletes, etc on a memory disk, but nothing > formal. I don't (currently) have a spare blank disk or space on an > existing disk to test on physical media, but I can look into doing so > once my development box is back up and running. > > I'm also curious what about the changes you feel are dangerous, so > I can target the testing to exercise the boundary conditions or > circumstances you think this patch would elicit problems. I do not suggest testing. I suggest understand what inode metadata is stored in the added 128 bytes and evaluate whether this information can be ignored without dangerous consequences for filesystem consistency or user data. --YrQNB5Deg1WGKZi3 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkksC4sACgkQC3+MBN1Mb4jj1QCfaVNB2QHYcaUXwA/t2L1v96Lr y4gAmwfewF0Ox1PUlLFkRCj8QFLQnVGu =u/UR -----END PGP SIGNATURE----- --YrQNB5Deg1WGKZi3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081125142827.GI2042>