Date: Fri, 15 Mar 2019 22:57:29 +0800 From: Marcelo Araujo <araujobsdport@gmail.com> To: Ian Lepore <ian@freebsd.org> Cc: "Rodney W. Grimes" <rgrimes@freebsd.org>, Chuck Tuffli <chuck@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r345171 - head/usr.sbin/bhyve Message-ID: <CAOfEmZgAjY3oaP6Koi1ar5jdk_Kz-g0mMsen9Z=ajQt04qMnxA@mail.gmail.com> In-Reply-To: <7e312cdad08139c567cd43207191c97303831e9d.camel@freebsd.org> References: <201903150231.x2F2VnR6027995@gndrsh.dnsmgr.net> <7e312cdad08139c567cd43207191c97303831e9d.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Em sex, 15 de mar de 2019 =C3=A0s 22:12, Ian Lepore <ian@freebsd.org> escre= veu: > On Thu, 2019-03-14 at 19:31 -0700, Rodney W. Grimes wrote: > > > Author: chuck > > > Date: Fri Mar 15 02:11:28 2019 > > > New Revision: 345171 > > > URL: https://svnweb.freebsd.org/changeset/base/345171 > > > > > > Log: > > > Fix bhyve PCIe capability emulation > > > > > > PCIe devices starting with version 1.1 must set the Role-Based > > > Error > > > Reporting bit. > > > > > > And while we're in the neighborhood, generalize the code > > > assigning the > > > device type. > > > > > > Reviewed by: imp, araujo, rgrimes > > > Approved by: imp (mentor) > > > MFC after: 1 week > > > Differential Revision: https://reviews.freebsd.org/D19580 > > > > This code requires maintainer approval before a commit, > > though this was well reviewed that doesnt exclude it > > from the MAINTAINERS entry. > > > > Where exactly does it say that in MAINTAINERS? As another victim of > this sort of drive-by lynching after making a trivial bhyve change I > pretty seriously object to a vague and meaningless entry in MAINTAINERS > being used to pounce on anyone who dares to touch the precious bhyve > code. > There is a new entry on MAINTAINERS: https://svnweb.freebsd.org/base?view=3Drevision&revision=3D344631 > > There is no mention of bhyve in MAINTAINERS, for usr.sbin or elsewhere. > There is an entry for vmm(4), which to me does not say anything about > bhyve, yet somehow everybody is supposed to know what it means and > what-all territory it covers? > > IMO, this sort of hyper-proprietary pouncing on everyone who dares > change a single line of code is not productive. It is HIGHLY de- > motivating. Large sweeping design changes are one thing, but pouncing > on every tiny minor commit is just not helpful. > +1 I got so frustrated with it recently that I have decided to don't contribute with bhyve anymore, perhaps even with FreeBSD. I still have some people under mentorship that I intend to finish and then probably I will phase out. > > -- Ian > > > Leave it for now, I am sure jhb or thyco are fine with it, > > this is just a heads up FYI for future commits. > > > > Bhyve code has been and still is under a fairly tight > > MAINTAINER status. > > > > > Modified: > > > head/usr.sbin/bhyve/pci_emul.c > > > > > > Modified: head/usr.sbin/bhyve/pci_emul.c > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > --- head/usr.sbin/bhyve/pci_emul.c Fri Mar 15 02:11:27 2019 (= r3 > > > 45170) > > > +++ head/usr.sbin/bhyve/pci_emul.c Fri Mar 15 02:11:28 2019 (= r3 > > > 45171) > > > @@ -953,7 +953,10 @@ pci_emul_add_pciecap(struct pci_devinst *pi, > > > int type) > > > bzero(&pciecap, sizeof(pciecap)); > > > > > > pciecap.capid =3D PCIY_EXPRESS; > > > - pciecap.pcie_capabilities =3D PCIECAP_VERSION | > > > PCIEM_TYPE_ROOT_PORT; > > > + pciecap.pcie_capabilities =3D PCIECAP_VERSION | type; > > > + /* Devices starting with version 1.1 must set the RBER bit */ > > > + if (PCIECAP_VERSION >=3D 1) > > > + pciecap.dev_capabilities =3D PCIEM_CAP_ROLE_ERR_RPT; > > > pciecap.link_capabilities =3D 0x411; /* gen1, x1 */ > > > pciecap.link_status =3D 0x11; /* gen1, x1 */ > > > > > > > > > > > > > > > > --=20 --=20 Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org <http://www.freebsd.org/>; \/ \ ^ Power To Server. .\. /_)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfEmZgAjY3oaP6Koi1ar5jdk_Kz-g0mMsen9Z=ajQt04qMnxA>