Date: Sat, 20 Apr 2002 11:02:10 -0400 (EDT) From: Robert Watson <rwatson@FreeBSD.org> To: "Andrey A. Chernov" <ache@nagual.pp.ru> Cc: "Jacques A. Vidrine" <nectar@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/crypto/openssh servconf.c session.c Message-ID: <Pine.NEB.3.96L.1020420105801.64976R-100000@fledge.watson.org> In-Reply-To: <20020420145437.GB5350@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 20 Apr 2002, Andrey A. Chernov wrote: > > Yeah, personally I'd prefer we avoid introducing gratuitous diffs against > > the OpenSSH source -- some changes are necessary (PAM, et al), but > > anything beyond the base necessary changes just makes updating more of a > > pain. We've already had updates stalled by >6-8 months because of many > > local changes, so that's a problem we need to be very careful to avoid. > > Please note that "CheckMail" was in OpenSSH since long time and was > removed just recently, making lack of "login" look & feel without any > reason. Moreover, old "ssh" (pre-OpenSSH) check mail too without any > option, like "login" does. > > Users really want to know they have new mail when they logged in! > > About setusercontext() changes: they are absolutely necessary, if we > support login.conf. We can either remove them with whole login.conf > support (why we have login.conf so?) or do it correctly. We can't live > with half-singing half-dancing old variant, I mean broken login.conf > support. Note that I wasn't necessarily making the judgement that your changes were gratuitous, just cautioning against gratuitous changes. :-) Having correct functioning of user context is a very good thing, and something where there have been bugs previously (I haven't had a chance to do tests to make sure they didn't recur with the recent upgrades, and need to do that actually). On the other hand, we need to find a good balance between local changes and merged ones -- I know that there have been some problems getting stuff merged back into the base distribution in the past, but for legitimate bug/feature fixes, it's important we make the effort. Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1020420105801.64976R-100000>