Date: Sun, 21 Sep 2025 10:17:51 -0700 From: Adrian Chadd <adrian@freebsd.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: bz@freebsd.org, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 785edcc2af5a - main - net80211: convert the rest of the native net80211 drivers to SEQNO_OFFLOAD Message-ID: <CAJ-Vmo=t8Zdjz7%2B_-pE8x0tk=XQASpAfX%2BvFGk8M0Ess9s_W9Q@mail.gmail.com> In-Reply-To: <aM-3ToTQy0MloNXA@cell.glebi.us> References: <202509200047.58K0lcgE017026@gitrepo.freebsd.org> <aM-3ToTQy0MloNXA@cell.glebi.us>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000aa5141063f52e24e Content-Type: text/plain; charset="UTF-8" On Sun, 21 Sept 2025 at 01:29, Gleb Smirnoff <glebius@freebsd.org> wrote: > Hi, > > On Sat, Sep 20, 2025 at 12:47:38AM +0000, Adrian Chadd wrote: > A> commit 785edcc2af5ae32c24f5caf5b9552f62bdae33ee > A> Author: Adrian Chadd <adrian@FreeBSD.org> > A> AuthorDate: 2025-06-10 04:22:10 +0000 > A> Commit: Adrian Chadd <adrian@FreeBSD.org> > A> CommitDate: 2025-09-20 00:42:45 +0000 > A> > A> net80211: convert the rest of the native net80211 drivers to > SEQNO_OFFLOAD > A> > A> * Convert the rest of the drivers to implement driver/offloaded > sequence > A> number handling. > A> > A> * For drivers that implement their own sequence number space > handling > A> for A-MPDU, only call ieee80211_output_seqno_assign() if the frame > A> isn't tagged with M_AMPDU_MPDU, which mirrors the original > net80211 > A> sequence number behaviour. (Except of course, the assignment is > A> now happening during final encap/transmit, not early in encap.) > A> > A> Locally tested (sta mode): > A> > A> * ath > A> * iwn > A> * bwi > A> * bwn > A> * iwm > A> * otus > A> * ral > A> > A> Differential Revision: https://reviews.freebsd.org/D50772 > A> Okayed by: bz > > This commit broke my iwm(4) on Thinkpad X1 Carbon 7th Gen. > > The symptoms are that the interface can associate and even receive DHCP > address, but after that all transmitted packets are lost. Any > communication > attempt results in ARP requests that are not seen by other devices on the > network. Reverting this commit resolves the problem. > > I will be able to test patches tomorrow, please send them to me. > > If we are not able to resolve that before start of the stabweek which is > this > Monday, I'd like to get this reverted from main. > Yup, I figured it out pretty quickly after it was first reported. See: https://reviews.freebsd.org/D52652 It looks like different generations of firmware/chipsets have different expectations for sequence numbers being present. I'm going to land this once kevans (and/or you?) test it out and OK it. Sorry! -a > > -- > Gleb Smirnoff > --000000000000aa5141063f52e24e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g= mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Sun, 21 Sept= 2025 at 01:29, Gleb Smirnoff <<a href=3D"mailto:glebius@freebsd.org">gl= ebius@freebsd.org</a>> wrote:<br></div><blockquote class=3D"gmail_quote"= style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);p= adding-left:1ex">=C2=A0 Hi,<br> <br> On Sat, Sep 20, 2025 at 12:47:38AM +0000, Adrian Chadd wrote:<br> A> commit 785edcc2af5ae32c24f5caf5b9552f62bdae33ee<br> A> Author:=C2=A0 =C2=A0 =C2=A0Adrian Chadd <adrian@FreeBSD.org><br= > A> AuthorDate: 2025-06-10 04:22:10 +0000<br> A> Commit:=C2=A0 =C2=A0 =C2=A0Adrian Chadd <adrian@FreeBSD.org><br= > A> CommitDate: 2025-09-20 00:42:45 +0000<br> A> <br> A>=C2=A0 =C2=A0 =C2=A0net80211: convert the rest of the native net80211 = drivers to SEQNO_OFFLOAD<br> A>=C2=A0 =C2=A0 =C2=A0<br> A>=C2=A0 =C2=A0 =C2=A0* Convert the rest of the drivers to implement dri= ver/offloaded sequence<br> A>=C2=A0 =C2=A0 =C2=A0 =C2=A0number handling.<br> A>=C2=A0 =C2=A0 =C2=A0<br> A>=C2=A0 =C2=A0 =C2=A0* For drivers that implement their own sequence nu= mber space handling<br> A>=C2=A0 =C2=A0 =C2=A0 =C2=A0for A-MPDU, only call ieee80211_output_seqn= o_assign() if the frame<br> A>=C2=A0 =C2=A0 =C2=A0 =C2=A0isn't tagged with M_AMPDU_MPDU, which m= irrors the original net80211<br> A>=C2=A0 =C2=A0 =C2=A0 =C2=A0sequence number behaviour.=C2=A0 (Except of= course, the assignment is<br> A>=C2=A0 =C2=A0 =C2=A0 =C2=A0now happening during final encap/transmit, = not early in encap.)<br> A>=C2=A0 =C2=A0 =C2=A0<br> A>=C2=A0 =C2=A0 =C2=A0Locally tested (sta mode):<br> A>=C2=A0 =C2=A0 =C2=A0<br> A>=C2=A0 =C2=A0 =C2=A0* ath<br> A>=C2=A0 =C2=A0 =C2=A0* iwn<br> A>=C2=A0 =C2=A0 =C2=A0* bwi<br> A>=C2=A0 =C2=A0 =C2=A0* bwn<br> A>=C2=A0 =C2=A0 =C2=A0* iwm<br> A>=C2=A0 =C2=A0 =C2=A0* otus<br> A>=C2=A0 =C2=A0 =C2=A0* ral<br> A>=C2=A0 =C2=A0 =C2=A0<br> A>=C2=A0 =C2=A0 =C2=A0Differential Revision:=C2=A0 <a href=3D"https://re= views.freebsd.org/D50772" rel=3D"noreferrer" target=3D"_blank">https://revi= ews.freebsd.org/D50772</a><br> A>=C2=A0 =C2=A0 =C2=A0Okayed by: bz<br> <br> This commit broke my iwm(4) on Thinkpad X1 Carbon 7th Gen.<br> <br> The symptoms are that the interface can associate and even receive DHCP<br> address, but after that all transmitted packets are lost.=C2=A0 Any communi= cation<br> attempt results in ARP requests that are not seen by other devices on the<b= r> network.=C2=A0 Reverting this commit resolves the problem.<br> <br> I will be able to test patches tomorrow, please send them to me.<br> <br> If we are not able to resolve that before start of the stabweek which is th= is<br> Monday, I'd like to get this reverted from main.<br></blockquote><div><= br></div><div>Yup, I figured it out pretty quickly after it was first repor= ted.</div><div><br></div><div>See:=C2=A0<a href=3D"https://reviews.freebsd.= org/D52652">https://reviews.freebsd.org/D52652</a></div><div><br></div><div= >It looks like different generations of firmware/chipsets have different ex= pectations for</div><div>sequence numbers being present. I'm going to l= and this once kevans (and/or you?)</div><div>test it out and OK it.</div><d= iv><br></div><div>Sorry!</div><div><br></div><div><br></div><div><br></div>= <div>-a</div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"ma= rgin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:= 1ex"> <br> -- <br> Gleb Smirnoff<br> </blockquote></div></div> --000000000000aa5141063f52e24e--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmo=t8Zdjz7%2B_-pE8x0tk=XQASpAfX%2BvFGk8M0Ess9s_W9Q>