Date: Sat, 6 Oct 2007 22:07:43 +0200 From: Erik Trulsson <ertr1013@student.uu.se> To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= <des@des.no> Cc: Scott Long <scottl@samsco.org>, src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, Jack Vogel <jfvogel@gmail.com>, Jack F Vogel <jfv@freebsd.org> Subject: Re: cvs commit: src/sys/conf files kern.pre.mk src/sys/dev/em LICENSE e1000_80003es2lan.c e1000_80003es2lan.h e1000_82540.c e1000_82541.c e1000_82541.h e1000_82542.c e1000_82543.c e1000_82543.h e1000_82571.c e1000_82571.h e1000_82575.c ... Message-ID: <20071006200743.GA24686@owl.midgard.homeip.net> In-Reply-To: <86odfcvx3x.fsf@ds4.des.no> References: <200710052249.l95Mn9Nb071852@repoman.freebsd.org> <20071005231538.GA24016@owl.midgard.homeip.net> <2a41acea0710051705l217224b6vc705dc6139b94e3b@mail.gmail.com> <20071006004634.GA24962@owl.midgard.homeip.net> <47073AF5.1010109@samsco.org> <86d4vspk8j.fsf@ds4.des.no> <47079A5C.3090109@samsco.org> <86odfcvx3x.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Oct 06, 2007 at 09:53:06PM +0200, Dag-Erling Sm=F8rgrav wrote: > Scott Long <scottl@samsco.org> writes: > > Dag-Erling Sm=F8rgrav <des@des.no> writes: > > > We used to have a principle that commit bits were granted to individu= als > > > on their individual merit, not simply because they represented a vend= or > > > and were paid to work on drivers for that vendor's hardware. > > Are you implying that Jack has no merit? That's an unfortunate > > assertion. What evidence do you have to support that? >=20 > It is you who implied rather strongly that Jack is neither more nor less > than an Intel representative. You spoke of "lecturing a vendor" when > all Erik did was point out or own rules to a *committer*. >=20 > > > We also used to have a principle that changes should be tested > > > before being committed, especially to -STABLE. > > I guess you missed that part where Jack said that the changes had > > undergone extensive testing. >=20 > I guess you missed the part where his commit broke the tinderbox, > because he clearly did not test the DEVICE_POLLING case. In Jack's defense that particular problem was apparently beacuse a 7.x interface was left in the code (bus_setup_intr(9) takes one more argument in 7.x than it does in 6.x.) That would not have been caught by having the code go into -CURRENT first. --=20 <Insert your favourite quote here.> Erik Trulsson ertr1013@student.uu.se
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071006200743.GA24686>