Date: Thu, 9 Jun 2016 10:09:06 -0400 From: Warner Losh <wlosh@bsdimp.com> To: Emmanuel Vadot <manu@bidouilliste.com> Cc: Emmanuel Vadot <manu@FreeBSD.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r301714 - head/sys/boot/efi/libefi Message-ID: <012000B7-2E79-48BE-B0AB-6C0D39DF8EAA@bsdimp.com> In-Reply-To: <20160609144304.05437ef3d7f2fe9cd26704ac@bidouilliste.com> References: <201606090202.u5922pwl024436@repo.freebsd.org> <90D3441D-D130-4D00-A12D-F4D3B81E606B@bsdimp.com> <20160609144304.05437ef3d7f2fe9cd26704ac@bidouilliste.com>
next in thread | previous in thread | raw e-mail | index | archive | help
We already have debugging framework for boot1.efi which we could use = here? I=E2=80=99m working on setting / getting of UEFI variables with support = for UEFI=E2=80=99s bootmgr protocol. That=E2=80=99s going to need some = way to debug it because it=E2=80=99s kinda complex... Warner > On Jun 9, 2016, at 8:43 AM, Emmanuel Vadot <manu@bidouilliste.com> = wrote: >=20 >=20 > I wanted to more verbose in case of the system don't have partition o > n disk (or the EFI implementation only support raw disks like U-Boot) > but this might be a bad way of doing saw, I didn't think about the > implication you're talking about. I'll try to figure a better way to = do > this. >=20 > On Wed, 8 Jun 2016 22:21:36 -0400 > Warner Losh <wlosh@bsdimp.com> wrote: >=20 >>=20 >>> On Jun 8, 2016, at 10:02 PM, Emmanuel Vadot <manu@FreeBSD.org> = wrote: >>>=20 >>> Author: manu >>> Date: Thu Jun 9 02:02:50 2016 >>> New Revision: 301714 >>> URL: https://svnweb.freebsd.org/changeset/base/301714 >>>=20 >>> Log: >>> Print a message when the efi disk isn't a logical partition. >>=20 >> Why on earth would you do that? This will print a message, one per = full disk, and our systems have 36 disks in them? >> Please consider backing this out... >>=20 >> Warner >>=20 >>=20 >>> Approved by: andrew (mentor) >>> Differential Revision: https://reviews.freebsd.org/D6782 >>>=20 >>> Modified: >>> head/sys/boot/efi/libefi/efipart.c >>>=20 >>> Modified: head/sys/boot/efi/libefi/efipart.c >>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- head/sys/boot/efi/libefi/efipart.c Thu Jun 9 01:50:43 2016 = (r301713) >>> +++ head/sys/boot/efi/libefi/efipart.c Thu Jun 9 02:02:50 2016 = (r301714) >>> @@ -119,8 +119,11 @@ efipart_init(void)=20 >>> (void**)&blkio); >>> if (EFI_ERROR(status)) >>> continue; >>> - if (!blkio->Media->LogicalPartition) >>> + if (!blkio->Media->LogicalPartition) { >>> + printf("%s%d isn't a logical partition, = skipping\n", >>> + efipart_dev.dv_name, n); >>> continue; >>> + } >>>=20 >>> /* >>> * If we come across a logical partition of subtype = CDROM >>>=20 >=20 >=20 > --=20 > Emmanuel Vadot
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?012000B7-2E79-48BE-B0AB-6C0D39DF8EAA>