Date: Sat, 16 Jun 2012 11:41:20 +0200 From: Tijl Coosemans <tijl@coosemans.org> To: Konstantin Belousov <kib@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r236976 - head/sbin/fsck_ffs Message-ID: <4FDC54C0.3030105@coosemans.org> In-Reply-To: <201206122137.q5CLbReK077123@svn.freebsd.org> References: <201206122137.q5CLbReK077123@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12-06-2012 23:37, Konstantin Belousov wrote: > Author: kib > Date: Tue Jun 12 21:37:27 2012 > New Revision: 236976 > URL: http://svn.freebsd.org/changeset/base/236976 > > Log: > For incompleted block allocations or frees, the inode block count usage > must be recalculated. The blk_check pass of suj checker explicitely marks > inodes which owned such blocks as needing block count adjustment. But > ino_adjblks() is only called by cg_trunc pass, which is performed before > blk_check. As result, the block use count for such inodes is left wrong. > This causes full fsck run after journaled run to still find inconsistencies > like 'INCORRECT BLOCK COUNT I=14557 (328 should be 0)' in phase 1. > > Fix this issue by running additional adj_blk pass after blk_check, which > updates the field. > > Reviewed by: jeff, mckusick > MFC after: 1 week Thanks! This probably fixes http://www.freebsd.org/cgi/query-pr.cgi?pr=165950
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FDC54C0.3030105>