Date: Sun, 04 Dec 2016 13:53:49 -0800 From: John Baldwin <jhb@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Andrey Chernov <ache@freebsd.org>, "stable@freebsd.org" <stable@freebsd.org> Subject: Re: if_cxgbev build error on -stable Message-ID: <1720335.GyareAB9U2@ralph.baldwin.cx> In-Reply-To: <20161204135323.GU54029@kib.kiev.ua> References: <ca38a6a0-a24e-4d10-4c1e-bd1f83679432@freebsd.org> <a3d2151e-3afb-5e0a-d320-3f35db93bc5f@freebsd.org> <20161204135323.GU54029@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday, December 04, 2016 03:53:23 PM Konstantin Belousov wrote: > On Sun, Dec 04, 2016 at 04:23:00PM +0300, Andrey Chernov wrote: > > It seems counter.h is included before systm.h where critical_* are declared. > It is more weird, since sys/counter.h was added in the stable/10 > merge, but the header is not used in the HEAD sources. It is indeed > needed for stable/10 driver. critical_enter() pre-requisite for counter.h > only exists on i386, which probably explains why John' build test did not > catched it. > > I am preparing another MFC, so I committed the fix in r309529. Thanks for fixing this. I had indeed only tested it on amd64. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1720335.GyareAB9U2>