Date: Mon, 31 Dec 2001 10:18:27 +0100 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Jake Burkholder <jake@locore.ca> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 trap.c Message-ID: <43558.1009790307@critter.freebsd.dk> In-Reply-To: Your message of "Sun, 30 Dec 2001 21:10:02 EST." <20011230211002.C9752@locore.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20011230211002.C9752@locore.ca>, Jake Burkholder writes:
>Apparently, On Sun, Dec 30, 2001 at 11:43:59AM -0800,
> Poul-Henning Kamp said words to the effect of;
>
>> phk 2001/12/30 11:43:59 PST
>>
>> Modified files:
>> sys/i386/i386 trap.c
>> Log:
>> GC an alternate trap_pfault() which has rotted away behind an "#ifdef notyet"
>> since 21-Mar-95 .
>>
>> Revision Changes Path
>> 1.210 +0 -118 src/sys/i386/i386/trap.c
>
>This is the one that should have been used. The existing one is broken because
>it allows faults on user memory in kernel mode without using copy{in,out} or
>{f,s}uword. Apparently there is still broken kernel code that expects this to
>work.
Well, whenever it can be used it can be resurrected from the CVS file.
Six years behind "#ifdef notyet" is above quota for any piece of code.
--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?43558.1009790307>