Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 27 Jan 2002 14:53:56 +1030
From:      Greg Lehey <grog@FreeBSD.org>
To:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/dev/vinum vinumconfig.c vinumioctl.c
Message-ID:  <20020127145356.C41130@wantadilla.lemis.com>
In-Reply-To: <200201270420.g0R4KrU26853@freefall.freebsd.org>
References:  <200201270420.g0R4KrU26853@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday, 26 January 2002 at 20:20:53 -0800, Greg Lehey wrote:
> grog        2002/01/26 20:20:53 PST
>
>   Modified files:
>     sys/dev/vinum        vinumconfig.c vinumioctl.c
>   Log:
>   vinumioctl: Fix a double fault caused by calling setjmp() without holding the config lock.  The call was in fact superfluous.
>
>   Revision  Changes    Path
>   1.44      +3 -1      src/sys/dev/vinum/vinumconfig.c
>   1.32      +0 -3      src/sys/dev/vinum/vinumioctl.c

Grrr.  Wrong text.  Should be:

  vinumioctl: Fix a double fault caused by calling setjmp() without
                    holding the config lock.  The call was in fact
                    superfluous.
  
  throw_rude_remark: Make sure we're holding the config lock before
                     proceeding.  There's no reason to assume that this
                     has ever happened, but the alternative might be a
                     double fault.
  
  Dump analysis by:  Thomas Moestl <tmoestl@gmx.net>
  MFC after:         approval by re.

Greg
--
See complete headers for address and phone numbers

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020127145356.C41130>