Date: Thu, 22 Feb 2018 09:24:21 -0700 From: Warner Losh <imp@bsdimp.com> To: Kyle Evans <kevans@freebsd.org> Cc: Alan Somers <asomers@freebsd.org>, Wojciech Macek <wma@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme Message-ID: <CANCZdfrrf9ZEMfrFcNF4113M9ap1jPQTCYkm6tJhb-%2BSS=0Xcw@mail.gmail.com> In-Reply-To: <CACNAnaE4Cb69X29MtqBvtercJZurVUVkgKQ-9-f541_G6bxq7w@mail.gmail.com> References: <201802221332.w1MDWVao004564@repo.freebsd.org> <CAOtMX2iP6fHQz%2BEKmKLQu_EUdydxh0hY9gxPPygUucn1T-2fxw@mail.gmail.com> <CACNAnaE4Cb69X29MtqBvtercJZurVUVkgKQ-9-f541_G6bxq7w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 22, 2018 at 9:20 AM, Kyle Evans <kevans@freebsd.org> wrote: > On Thu, Feb 22, 2018 at 10:19 AM, Alan Somers <asomers@freebsd.org> wrote: > > On Thu, Feb 22, 2018 at 6:32 AM, Wojciech Macek <wma@freebsd.org> wrote: > > > >> Author: wma > >> Date: Thu Feb 22 13:32:31 2018 > >> New Revision: 329824 > >> URL: https://svnweb.freebsd.org/changeset/base/329824 > >> > >> Log: > >> NVMe: Add big-endian support > >> > >> Remove bitfields from defined structures as they are not portable. > >> Instead use shift and mask macros in the driver and nvmecontrol > >> application. > >> > >> NVMe is now working on powerpc64 host. > >> > >> Submitted by: Michal Stanek <mst@semihalf.com> > >> Obtained from: Semihalf > >> Reviewed by: imp, wma > >> Sponsored by: IBM, QCM Technologies > >> Differential revision: https://reviews.freebsd.org/D13916 > >> > > > > It looks like this change broke the build with Clang: > > > > Fixed in r329827... all little endian arch's broken, not so great. =( > At least the kernel is passing my tests this morning... I didn't think this was ready and hasn't yet lifted my objections in the review... Not sure I want to get grumpy about it yet, but I'm not pleased to see this. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrrf9ZEMfrFcNF4113M9ap1jPQTCYkm6tJhb-%2BSS=0Xcw>