Date: Thu, 4 Mar 2010 12:14:07 -0700 From: Scott Long <scottl@samsco.org> To: "M. Warner Losh" <imp@bsdimp.com> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, ed@FreeBSD.org Subject: Re: svn commit: r194266 - head/usr.bin/chpass Message-ID: <DA308DE7-889E-4742-A703-62F245B808EF@samsco.org> In-Reply-To: <20100304.115305.769599705400649806.imp@bsdimp.com> References: <CADA450C-C67C-47DA-BF64-40FFE011B1E9@samsco.org> <20100304.105304.29649700129034.imp@bsdimp.com> <9A8644AD-3B92-4BCE-8A51-132F8EA35F7D@samsco.org> <20100304.115305.769599705400649806.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mar 4, 2010, at 11:53 AM, M. Warner Losh wrote: > In message: <9A8644AD-3B92-4BCE-8A51-132F8EA35F7D@samsco.org> > Scott Long <scottl@samsco.org> writes: > : On Mar 4, 2010, at 10:53 AM, M. Warner Losh wrote: > : >=20 > : > In message: <CADA450C-C67C-47DA-BF64-40FFE011B1E9@samsco.org> > : > Scott Long <scottl@samsco.org> writes: > : > : Forcing the entire build to fail if chflags fails breaks = installing > : > : to an NFS destination. I haven't tested all possible = permutations > : > : of src vs dest filesystems mounting, but I don't see how it can > : > : work over any type of NFS mount. What is the reason for forcing > : > : this failure? The NO_FSCHG variable is undocumented, and the > : > : failure mode here is pretty useless at helping the user fix the > : > : problem. I'd like to re-add the '-' modifier to the chflags > : > : command that you removed. > : >=20 > : > NO_FSCHG variable has been around a long time, and is de-facto > : > supported. It will be documented shortly when I get done cleaning = up > : > build(7). > : >=20 > : > NO_FSCHG has been the documented way (in examples) for installing = over > : > NFS for a very long time. It looks to my eye like this change = fixed a > : > problem with that... > : >=20 > : > Warner > : >=20 > : > :=20 > :=20 > : Every other base package that sets schg does so by allowing chflags = to silently fail. My change puts chpass back into conformance with the = status quo. >=20 > Well, maybe for chflags, but not for install. You still need NO_FSCHG > if you are installing over NFS, with or without this change... >=20 What am I missing by not using it? Just a few minutes ago I did a = successful install over NFS on 9-current and 7-stable. Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DA308DE7-889E-4742-A703-62F245B808EF>