Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 10 Mar 2009 22:54:29 +0000 (GMT)
From:      Robert Watson <rwatson@FreeBSD.org>
To:        Doug Barton <dougb@FreeBSD.org>
Cc:        Lawrence Stewart <lstewart@freebsd.org>, src-committers@freebsd.org, Luigi Rizzo <rizzo@iet.unipi.it>, svn-src-user@freebsd.org
Subject:   Re: svn commit: r189612 - in user/lstewart/alq_varlen_8.x: sys/kern tools/test/alq
Message-ID:  <alpine.BSF.2.00.0903102253400.92752@fledge.watson.org>
In-Reply-To: <49B6DEED.4040902@FreeBSD.org>
References:  <200903100751.n2A7p02m050724@svn.freebsd.org> <49B6CF13.9060501@FreeBSD.org> <20090310212511.GA53115@onelab2.iet.unipi.it> <49B6DEED.4040902@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 10 Mar 2009, Doug Barton wrote:

>>> Generally it's preferred not to mix these two types of changes. The 
>>> preferred course of action is to make the style changes, confirm that the 
>>> binary is unchanged (e.g., with sha256), then do substantive changes. 
>>> Makes the revision history a little easier to parse down the road.
>>
>> well, this is a private branch after all :)
>
> 1. Good habits come from good practice, and what better place to practice 
> than in a "private" branch?
>
> 2. Given that the stuff is in the FreeBSD repository, the presumption is 
> that it is of some use to the wider FreeBSD community. So IMO community best 
> practices are a reasonable expectation. Otherwise, why not just keep it 
> local?

Also, if the plan is to use svn merge to pull the changes back from a work 
branch into the main branch, revision history from that branch will be seen by 
people tracking the recursive history of changes in the main branch.

Robert N M Watson
Computer Laboratory
University of Cambridge



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.0903102253400.92752>