Date: Fri, 29 Jul 2016 20:07:21 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Bruce Evans <brde@optusnet.com.au> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r303502 - head/usr.bin/indent Message-ID: <8aa1f19c-3bdb-7acf-9cc1-66082cbbc400@FreeBSD.org> In-Reply-To: <20160730092525.N1012@besplex.bde.org> References: <201607291936.u6TJaALj035130@repo.freebsd.org> <20160730092525.N1012@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07/29/16 19:00, Bruce Evans wrote: > On Fri, 29 Jul 2016, Pedro F. Giffuni wrote: > >> Log: >> indent(1): Use NULL instead of zero for pointers. > > This is probably not indent's style, I doubt that you found all of the > implicit NULLs. A recent commit added strstr() without even a comparison > with 0. > > This adds some lexical style bugs. > Yikes... hurry doesn't help get commits right. Sorry. Hope r303525 is not worse than what we had before. Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8aa1f19c-3bdb-7acf-9cc1-66082cbbc400>