Date: Thu, 22 Feb 2018 17:31:18 +0100 From: Wojciech Macek <wma@semihalf.com> To: Alan Somers <asomers@freebsd.org> Cc: Kyle Evans <kevans@freebsd.org>, Wojciech Macek <wma@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme Message-ID: <CANsEV8dtDme1jOs2Tzdnv3A3a_N-7tn=VO=L9%2BwG_VjEcvJ%2BXw@mail.gmail.com> In-Reply-To: <CAOtMX2gLkhmjf=4oh1zqFrxxBYnU1E1cacG2tK_sGCef48pcrg@mail.gmail.com> References: <201802221332.w1MDWVao004564@repo.freebsd.org> <CAOtMX2iP6fHQz%2BEKmKLQu_EUdydxh0hY9gxPPygUucn1T-2fxw@mail.gmail.com> <CACNAnaE4Cb69X29MtqBvtercJZurVUVkgKQ-9-f541_G6bxq7w@mail.gmail.com> <CAOtMX2gLkhmjf=4oh1zqFrxxBYnU1E1cacG2tK_sGCef48pcrg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Thanks and sorry for troubles! These lines must have got lost somewhere during rebase as we run tinderbox with this patch yesterday. Regards, Wojtek wma@ 2018-02-22 17:22 GMT+01:00 Alan Somers <asomers@freebsd.org>: > On Thu, Feb 22, 2018 at 9:20 AM, Kyle Evans <kevans@freebsd.org> wrote: > >> On Thu, Feb 22, 2018 at 10:19 AM, Alan Somers <asomers@freebsd.org> >> wrote: >> > On Thu, Feb 22, 2018 at 6:32 AM, Wojciech Macek <wma@freebsd.org> >> wrote: >> > >> >> Author: wma >> >> Date: Thu Feb 22 13:32:31 2018 >> >> New Revision: 329824 >> >> URL: https://svnweb.freebsd.org/changeset/base/329824 >> >> >> >> Log: >> >> NVMe: Add big-endian support >> >> >> >> Remove bitfields from defined structures as they are not portable. >> >> Instead use shift and mask macros in the driver and nvmecontrol >> >> application. >> >> >> >> NVMe is now working on powerpc64 host. >> >> >> >> Submitted by: Michal Stanek <mst@semihalf.com> >> >> Obtained from: Semihalf >> >> Reviewed by: imp, wma >> >> Sponsored by: IBM, QCM Technologies >> >> Differential revision: https://reviews.freebsd.org/D13916 >> >> >> > >> > It looks like this change broke the build with Clang: >> > >> >> Fixed in r329827... all little endian arch's broken, not so great. =( >> > > Fast work, Kyle. Thanks a bundle. > -Alan >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANsEV8dtDme1jOs2Tzdnv3A3a_N-7tn=VO=L9%2BwG_VjEcvJ%2BXw>