Date: Sun, 02 Sep 2001 08:51:17 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Matt Dillon <dillon@earth.backplane.com> Cc: Peter Wemm <peter@wemm.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_prof.c kern_ntptime.c kern_xxx.c Message-ID: <69327.999413477@critter> In-Reply-To: Your message of "Sat, 01 Sep 2001 01:27:32 PDT." <200109010827.f818RW370778@earth.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200109010827.f818RW370778@earth.backplane.com>, Matt Dillon writes:
>
>: static void
>: usage()
>: {
>: /* Insert an empty line if the function has no local variables. */
>
> You must be joking. Who came up with that carp? A blank line if
> the function has no local variables? In my entire life as a programmer
> I have never once seen that style. It looked like a mistake. If I
> see any more I won't take out the blank line but... no, I don't want to
> know whos idea it was.
Well, there must be a lot of the FreeBSD kernel you have never looked at.
It's very convenient to know that the first blank line in a function means
the end of local variables, it makes simple source-munging scripts much
easier.
Until such time as you negotiate a change in style(9) on this point,
you are just as bound by it as any other committer.
--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69327.999413477>