Date: Mon, 31 May 2010 00:00:55 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: hselasky@c2i.net Cc: perforce@freebsd.org, zec@freebsd.org, gcooper@freebsd.org Subject: Re: PERFORCE change 178978 for review Message-ID: <20100531.000055.923725949146439083.imp@bsdimp.com> In-Reply-To: <201005302101.02794.hselasky@c2i.net> References: <201005301444.o4UEidHb057496@repoman.freebsd.org> <AANLkTilpZTmKr3tTrfafgt5CtskJB3LMEM_XoOsJdKq2@mail.gmail.com> <201005302101.02794.hselasky@c2i.net>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <201005302101.02794.hselasky@c2i.net> Hans Petter Selasky <hselasky@c2i.net> writes: : On Sunday 30 May 2010 20:59:33 Garrett Cooper wrote: : > > if (version != 1) : > > - return (ENOPROTOOPT); : > > + return ENOPROTOOPT; : > : > That's actually a style regression (along with any other return calls : > without parentheses). : > : : FYI: : : Linux style mandatates return values without parentheses. And FreeBSD style : mandates that opposite! NetBSD style mandates their absence too... Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100531.000055.923725949146439083.imp>