Date: Wed, 23 May 2018 22:25:20 -0700 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Matthew Macy <mmacy@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333860 - head/sys/kern Message-ID: <20180524052520.GZ71675@FreeBSD.org> In-Reply-To: <CAPrugNri9xu6DeNR5pXWv6UjFEDuKuZD5LGbyvQAFKM-5F87mg@mail.gmail.com> References: <201805190510.w4J5AqfS054367@repo.freebsd.org> <20180523222743.GU71675@FreeBSD.org> <CAPrugNpKxEVx%2Bg0D6qUwq=yw_W-QeuntupwAjteK1yALkJktag@mail.gmail.com> <20180523225729.GV71675@FreeBSD.org> <CAPrugNpsiYQ1MKkgGbkwPEeTcsTCdD_u5GAvYpMJKHzeSbCL=w@mail.gmail.com> <20180524044252.GW71675@FreeBSD.org> <CAPrugNoVPCbB0qTY=Z1dwCZ%2BbCbVbA1d5b0-tw5qaPxWRK0q8g@mail.gmail.com> <20180524050717.GY71675@FreeBSD.org> <CAPrugNri9xu6DeNR5pXWv6UjFEDuKuZD5LGbyvQAFKM-5F87mg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, May 23, 2018 at 10:13:25PM -0700, Matthew Macy wrote: M> On Wed, May 23, 2018 at 10:07 PM, Gleb Smirnoff <glebius@freebsd.org> wrote: M> > Can you please explain the bug supposed to be fixed by r333860 QUESTION MARK M> M> Did I say it fixed a bug? Or are you saying we should just turn off M> compiler warnings because Gleb Smirnoff knows better? You just did say "Warnings find bugs PERIOD." This implicitly claimed that shutting this one fixed a bug. Indeed, I am saying that in this particular case Gleb Smirnoff knows better than gcc8 does. However, I'm not saying to turn off compiler warnings. Never said that. I am saying (several times already) not to insert redundant code to shut up a warning that is false. -- Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180524052520.GZ71675>