Date: Wed, 21 Nov 2018 10:41:37 -0600 From: Kyle Evans <kevans@freebsd.org> To: "Rodney W. Grimes" <rgrimes@freebsd.org> Cc: 0mp@freebsd.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r340722 - head/lib/libbe Message-ID: <CACNAnaE=78KLnEM1R-EZd_S0Dbqc1dG2O_Drq5CrGUg4cdUuhA@mail.gmail.com> In-Reply-To: <201811211618.wALGIt0N072613@pdx.rh.CN85.dnsmgr.net> References: <201811211122.wALBMiCt071058@repo.freebsd.org> <201811211618.wALGIt0N072613@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 21, 2018 at 10:19 AM Rodney W. Grimes <freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > Author: 0mp (ports committer) > > Date: Wed Nov 21 11:22:44 2018 > > New Revision: 340722 > > URL: https://svnweb.freebsd.org/changeset/base/340722 > > > > Log: > > libbe(3): Put each error value in separate line. > > > > As requested by a TODO in the source code. > > > > Reviewed by: bcr > > Approved by: krion (mentor, implicit), mat (mentor, implicit) > > Differential Revision: https://reviews.freebsd.org/D18063 > > Who with a src bit approved the commit to src? > I do want to clarify- bcr approved it in the review (explicitly with "... hereby approved!") -- are you mainly pointing out that he failed to annotate this properly in the commit, or is doc bit approval for a commit to a manpage in src insufficient? As an aside, happy to approve any changes to these manpages as the current bectl/libbe maintainer for anyone that wants to improve them. =) Thanks, Kyle Evans
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaE=78KLnEM1R-EZd_S0Dbqc1dG2O_Drq5CrGUg4cdUuhA>