Date: Sat, 14 Sep 2002 12:08:37 -0700 (PDT) From: Matthew Dillon <dillon@apollo.backplane.com> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: Bruce Evans <bde@zeta.org.au>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern vfs_bio.c src/sys/sys bio.h Message-ID: <200209141908.g8EJ8bUd052972@apollo.backplane.com> References: <10588.1032020135@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
:In message <20020914032217.V10972-100000@gamplex.bde.org>, Bruce Evans writes:
:
:>Isn't the "correct" locking just splbio() in RELENG_4 (if this function were
:>merged, haha) and Giant in -current. bufwait() just uses splbio()
:>unconditionally. Of course, Giant is not really correct.
:
:Forget -stable. In -current Giant would currently be a usable
:default, except that it would likely perform worse than the timeout
:currently used. Down the road Giant is almost guaranteed to be
:wrong, and therefore I didn't want to employ at this time.
:
:--
:Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
:phk@FreeBSD.ORG | TCP/IP since RFC 956
:FreeBSD committer | BSD since 4.3-tahoe
:Never attribute to malice what can adequately be explained by incompetence.
Well, the buffer is owned at the time of the BIO_DONE and you have
a lock structure sitting right there, why not simply use the
lock structure's interlock? Note I said 'interlock' here, not the
main lock.
-Matt
Matthew Dillon
<dillon@backplane.com>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200209141908.g8EJ8bUd052972>