Date: Tue, 14 Jan 2014 21:28:55 +0100 From: Julio Merino <julio@meroh.net> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Julio Merino <jmmv@FreeBSD.org>, src-committers@freebsd.org Subject: Re: svn commit: r260586 - head/bin/pax/tests Message-ID: <D128C9BF-9C8B-43C7-98DC-B49E5154B3A2@meroh.net> In-Reply-To: <01D805C2-AB9D-48F5-A972-FC7E801DC21E@meroh.net> References: <201401131217.s0DCHflD060494@svn.freebsd.org> <20140113135930.GR97375@ithaqua.etoilebsd.net> <01D805C2-AB9D-48F5-A972-FC7E801DC21E@meroh.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jan 13, 2014, at 15:34, Julio Merino <julio@meroh.net> wrote:
> On Jan 13, 2014, at 14:59, Baptiste Daroussin <bapt@FreeBSD.org> wrote:
>
>> On Mon, Jan 13, 2014 at 12:17:41PM +0000, Julio Merino wrote:
>>> +tap_test_program{name="legacy_test", required_programs="/usr/bin/perl"}
>>
>> Shouldn't that be /usr/local/bin/perl or ${LOCALBASE}/bin/perl, we are trying
>> hard on ports to remove by default /usr/bin/perl which is a legacy from the
>> removal of perl from base.
>
> Only if legacy_test.sh is also modified to use /usr/local/bin/perl. (I don't think using LOCALBASE is possible given that it's not accessible from share/mk/.)
>
> If it's the right thing to do, I can change it.
FTR, I did this change as part of some other generalizations and cleanups. Test programs that use the new TAP_TESTS_PERL feature of tap.test.mk should get the right path to the perl interpreter.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D128C9BF-9C8B-43C7-98DC-B49E5154B3A2>