Date: Wed, 24 Jul 2002 22:12:52 -0700 From: Brooks Davis <brooks@one-eyed-alien.net> To: Bruce Evans <bde@zeta.org.au> Cc: net@FreeBSD.ORG Subject: Re: ppp(4) cloning review request Message-ID: <20020724221252.A17223@Odin.AC.HMC.Edu> In-Reply-To: <20020724232548.W33495-100000@gamplex.bde.org>; from bde@zeta.org.au on Wed, Jul 24, 2002 at 11:36:50PM %2B1000 References: <20020723225859.A20811@Odin.AC.HMC.Edu> <20020724232548.W33495-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Wed, Jul 24, 2002 at 11:36:50PM +1000, Bruce Evans wrote: > On Tue, 23 Jul 2002, Brooks Davis wrote: > > > I have attached a patch which adds cloning and unloading support to the > > ppp(4) kernel PPP device. I would like to commit it in the next few > > days. Please review. > > ... > > - The unload is a bit ugly because line disciplines don't really > > appear to be meant to be unhooked. > > There is ldisc_deregister(). Using it might require using ldisc_register() > instead of rudely hacking on linesw[]. if_sl.c also has rude hacks, but > there are examples of using these interfaces in snp and netgraph. Thanks for the pointer. That helps a bit. Looking at the way line disciplines are used, I can't help but think that the current method of accessing them by index is a bit stupid. It's rather odd to have support for loadable disciplines, but no standard way to find out what is in each slot. -- Brooks -- Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE9P4jUXY6L6fI4GtQRAtQNAKDIM7AqWb3BEdOQMH0dRyzsuReTngCguGY0 y88r9ny3jrBwEhsouAYoalA= =ZC5+ -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020724221252.A17223>