Date: Wed, 06 Jun 2001 19:37:49 -0500 From: Richard Todd <rmtodd@ichotolot.servalan.com> To: current@freebsd.org Cc: peter@freebsd.org Subject: recent change to ata-disk.c seems to be horked... Message-ID: <m157no5-004MgFC@servalan.servalan.com>
next in thread | raw e-mail | index | archive | help
Just tried to build a kernel with freshly-supped sources and got:
cc -c -O -pipe -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -g -nostdinc -I- -I. -I../.. -I../../dev -I../../../include -I../../contrib/dev/acpica -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 ../../dev/ata/ata-disk.c
../../dev/ata/ata-disk.c:88: syntax error before `&'
../../dev/ata/ata-disk.c:55: warning: `adopen' used but never defined
../../dev/ata/ata-disk.c:56: warning: `adstrategy' used but never defined
../../dev/ata/ata-disk.c:57: warning: `addump' used but never defined
../../dev/ata/ata-disk.c:58: warning: `ad_cdevsw' defined but not used
../../dev/ata/ata-disk.c:73: warning: `addisk_cdevsw' defined but not used
../../dev/ata/ata-disk.c:76: warning: `ad_invalidatequeue' declared `static' but never defined
../../dev/ata/ata-disk.c:77: warning: `ad_tagsupported' declared `static' but never defined
../../dev/ata/ata-disk.c:78: warning: `ad_timeout' declared `static' but never defined
../../dev/ata/ata-disk.c:79: warning: `ad_free' declared `static' but never defined
../../dev/ata/ata-disk.c:80: warning: `ad_version' declared `static' but never defined
../../dev/ata/ata-disk.c:83: warning: `adp_lun_map' defined but not used
../../dev/ata/ata-disk.c:85: warning: `ata_dma' defined but not used
../../dev/ata/ata-disk.c:86: warning: `ata_wc' defined but not used
../../dev/ata/ata-disk.c:87: warning: `ata_tags' defined but not used
*** Error code 1
Stop in /usr/src/sys/compile/ICHOTOLOTSMP.
Line 88 is in the diffs that peter just recently committed (rev 1.106; see
the commitlogs/sys entry for 2001/06/06 15:17:09 PDT). The offending line
is
TUNABLE_INT("hw.ata.ata_dma", &ata_dma);
Looking at the definition of TUNABLE_INT, it doesn't look like it'd take well
to having the 2nd argument (var) be something beginning with &, given that the
first thing the definition does is try to define a function based on the var
given, in this case
static void __Tunable_&ata_dma (void *ignored)
See the problem?
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?m157no5-004MgFC>