Date: Mon, 11 Jun 2007 16:44:56 +0900 From: Pyun YongHyeon <pyunyh@gmail.com> To: Andre Oppermann <andre@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Pyun YongHyeon <yongari@freebsd.org> Subject: Re: cvs commit: src/sys/dev/msk if_msk.c Message-ID: <20070611074456.GE39661@cdnetworks.co.kr> In-Reply-To: <466CFBE2.1090907@freebsd.org> References: <200706110155.l5B1t9d9043150@repoman.freebsd.org> <466CFBE2.1090907@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 11, 2007 at 09:38:10AM +0200, Andre Oppermann wrote: > Pyun YongHyeon wrote: > >yongari 2007-06-11 01:55:09 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/msk if_msk.c > > Log: > > Disable automatic IP ID increment. Due to a hardware bug the automatic > > IP ID increment in TSO case generated corrupted IP packets. > > This change brings back TSO capability. > > > > Revision Changes Path > > 1.16 +0 -15 src/sys/dev/msk/if_msk.c > > Please add check for the DF (Don't fragment) bit in the IP header. > Otherwise we may run into trouble when fragmentation happens along > the path. We almost always set DF on TCP connections. If it is not > set please return EMSGSIZE which will cause TSO to be turned off. > Is there any way to return EMSGSIZE to upper layer? if_start has return type void. Or just dropping the packet if DF bit was not set is enough? -- Regards, Pyun YongHyeon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070611074456.GE39661>