Date: Mon, 29 Apr 2013 09:19:10 -0700 From: Adrian Chadd <adrian@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head <svn-src-head@freebsd.org>, Eitan Adler <eadler@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, src-committers <src-committers@freebsd.org>, hiren panchasara <hiren@freebsd.org> Subject: Re: svn commit: r249800 - head/sys/dev/bwn Message-ID: <CAJ-Vmon_C2%2BOZNxH74A0mY=qf3E%2Bm16aHwA8wri0xzJsfJ-LuA@mail.gmail.com> In-Reply-To: <201304291123.41402.jhb@freebsd.org> References: <201304231302.r3ND2w5V024981@svn.freebsd.org> <CALCpEUExXu%2BCsM4ORr=Z=tMXvLJSqQn-sEOwY0aQ6GHCHeA50w@mail.gmail.com> <CALCpEUH2NZHpx6e7SCJRFkHZo2TOzXiZRFt_9UpgVO9%2Bb13kFA@mail.gmail.com> <201304291123.41402.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 29 April 2013 08:23, John Baldwin <jhb@freebsd.org> wrote: >> - dr->setdesc(dr, desc, paddr, meta->mt_m->m_len - >> + dr->setdesc(dr, desc, meta->mt_paddr, meta->mt_m->m_len - >> sizeof(*hdr), 0, 0, 0); >> return (error); >> } > > I would leave the comment alone. In the common case you do allocate a new > mbuf so you aren't restoring the descriptor but setting it up with a new > address. The code change looks correct. Does anyone here have bwn hardware that works? Adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmon_C2%2BOZNxH74A0mY=qf3E%2Bm16aHwA8wri0xzJsfJ-LuA>