Date: Mon, 7 Jul 1997 18:43:43 PDT From: Bill Fenner <fenner@parc.xerox.com> To: Julian Elischer <julian@freebsd.org> Cc: cvs-committers@freebsd.org, cvs-all@freebsd.org, cvs-sys@freebsd.org Subject: Re: cvs commit: src/sys/net if.c Message-ID: <97Jul7.184349pdt.177512@crevenia.parc.xerox.com> In-Reply-To: Your message of "Mon, 07 Jul 97 10:36:06 PDT." <199707071736.KAA29158@freefall.freebsd.org>
index | next in thread | previous in thread | raw e-mail
This should have been a 3-line fix. I don't understand why you chose
to restructure the first section of code; it has now lost its
parallelism with the next place that looks for a multicast address on
the list.
(e.g. the 2nd bit is
for (ifma = ifp->if_multiaddrs.lh_first; ifma;
ifma = ifma->ifma_link.le_next) {
if (equal(ifma->ifma_addr, llsa))
break;
}
if (ifma) {
...
so why not leave the first bit looking like that too, or restructure
the 2nd bit in the same way you restructured the 1st bit?)
Bill
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?97Jul7.184349pdt.177512>