Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 24 Jul 2026 11:12:34 +0000
From:      Pouria Mousavizadeh Tehrani <pouria@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: daf57eb11505 - main - icmp: Verify redirect gateway with fib-aware ifa selection
Message-ID:  <6a6348a2.451b1.11c16ef1@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by pouria:

URL: https://cgit.FreeBSD.org/src/commit/?id=daf57eb115053613d01e338b9022db16c045f033

commit daf57eb115053613d01e338b9022db16c045f033
Author:     Pouria Mousavizadeh Tehrani <pouria@FreeBSD.org>
AuthorDate: 2026-07-23 09:10:32 +0000
Commit:     Pouria Mousavizadeh Tehrani <pouria@FreeBSD.org>
CommitDate: 2026-07-24 08:04:27 +0000

    icmp: Verify redirect gateway with fib-aware ifa selection
    
    During call to `icmp_verify_redirect_gateway()` ensure using
    fib-aware source address selection function.
    
    Reviewed by: glebius
    Differential Revision: https://reviews.freebsd.org/D58409
---
 sys/netinet/ip_icmp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sys/netinet/ip_icmp.c b/sys/netinet/ip_icmp.c
index adf69c47aed5..fd1a3cd24c8f 100644
--- a/sys/netinet/ip_icmp.c
+++ b/sys/netinet/ip_icmp.c
@@ -965,8 +965,7 @@ icmp_verify_redirect_gateway(struct sockaddr_in *src, struct sockaddr_in *dst,
 	if ((ifa = ifa_ifwithnet((struct sockaddr *)gateway, 0, fibnum))==NULL)
 		return (ENETUNREACH);
 
-	/* TODO: fib-aware. */
-	if (ifa_ifwithaddr_check((struct sockaddr *)gateway))
+	if (ifa_ifwithaddr_fib_check((struct sockaddr *)gateway, fibnum))
 		return (EHOSTUNREACH);
 
 	nh = fib4_lookup(fibnum, dst->sin_addr, 0, NHR_NONE, 0);


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a6348a2.451b1.11c16ef1>