Date: Fri, 14 Nov 2014 12:57:19 +0100 From: =?UTF-8?Q?Ermal_Lu=C3=A7i?= <eri@freebsd.org> To: Ilya Bakulin <ilya@bakulin.de> Cc: Freebsd hackers list <freebsd-hackers@freebsd.org>, freebsd-net <freebsd-net@freebsd.org>, J David <j.david.lists@gmail.com>, owner-freebsd-net@freebsd.org, "freebsd-pf@freebsd.org" <freebsd-pf@freebsd.org> Subject: Re: Checksumming outgoing packets in PF vs in ip[6]_output Message-ID: <CAPBZQG3GgS72wpTscxcQPA5pNSCimpFwquGC=4UOwY4tVyiQSA@mail.gmail.com> In-Reply-To: <9734b7d34828a102d9a2f5061c11ae3d@mail.bakulin.de> References: <d2f0c43909d9c9bada9a5bda7719cfca@mail.bakulin.de> <CABXB=RRWNX6NnxCbebig-L41W4n9ZSBDrzOWa_k_TVHowhSbYg@mail.gmail.com> <CAPBZQG1%2BVWZDYqwFjufO-hM58kbK_WLnnso_Dgsf=1nDQ%2Bi2Ww@mail.gmail.com> <9734b7d34828a102d9a2f5061c11ae3d@mail.bakulin.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--001a113817fcc0512c0507d054a5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Here is a direct patch. Give it a try. For the reply-to issues there is another patch complementary to this i will send. On Fri, Nov 14, 2014 at 11:34 AM, Ilya Bakulin <ilya@bakulin.de> wrote: > Hi all, > > actually with _my_ checksumming patch the rdr-to is broken completely :-( > So I'm waiting for Ermal to send an updated version of his patch that may > really solve the problem! > > > On 2014-11-14 09:17, Ermal Lu=C3=A7i wrote: > >> Yes confirmed it will solve that issue as well. >> >> On Thu, Nov 13, 2014 at 9:30 PM, J David <j.david.lists@gmail.com> wrote= : >> >> On Wed, Nov 5, 2014 at 9:28 AM, Ilya Bakulin <ilya@bakulin.de> wrote: >>> > Of course it was interesting what does the upstream PF do (@ OpenBSD)= . >>> Seems >>> > they have made the decision to >>> > leave the task of recalculating the checksums for outgoing packets to >>> > ip[6]_output, because currently >>> > the code there overwrites the checksum anyway. >>> > This seems a correct way to me. pf should not longer do any checksum >>> updates >>> > in inbound and outbound path. >>> >>> Is there any chance this change would help with bug 179392 as well? >>> >>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D179392 >>> >>> Or is that a separate issue? >>> >>> Thanks! >>> _______________________________________________ >>> freebsd-net@freebsd.org mailing list >>> http://lists.freebsd.org/mailman/listinfo/freebsd-net >>> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >>> >>> > --=20 Ermal --001a113817fcc0512c0507d054a5 Content-Type: application/octet-stream; name="pf_ipv6_checksum.patch" Content-Disposition: attachment; filename="pf_ipv6_checksum.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i2hhqx000 ZGlmZiAtLWdpdCBhL3N5cy9uZXRwZmlsL3BmL3BmX2lvY3RsLmMgYi9zeXMvbmV0cGZpbC9wZi9w Zl9pb2N0bC5jCmluZGV4IGRiYTU2NzQuLmNhN2Y4NTEgMTAwNjQ0Ci0tLSBhL3N5cy9uZXRwZmls L3BmL3BmX2lvY3RsLmMKKysrIGIvc3lzL25ldHBmaWwvcGYvcGZfaW9jdGwuYwpAQCAtNzYsNiAr NzYsNyBAQCBfX0ZCU0RJRCgiJEZyZWVCU0QkIik7CiAjaW5jbHVkZSA8bmV0aW5ldC9pbi5oPgog I2luY2x1ZGUgPG5ldGluZXQvaXAuaD4KICNpbmNsdWRlIDxuZXRpbmV0L2lwX3Zhci5oPgorI2lu Y2x1ZGUgPG5ldGluZXQ2L2lwNl92YXIuaD4KICNpbmNsdWRlIDxuZXRpbmV0L2lwX2ljbXAuaD4K IAogI2lmZGVmIElORVQ2CkBAIC0zNjE5LDEyICszNjIwLDkgQEAgcGZfY2hlY2s2X291dCh2b2lk ICphcmcsIHN0cnVjdCBtYnVmICoqbSwgc3RydWN0IGlmbmV0ICppZnAsIGludCBkaXIsCiAJaW50 IGNoazsKIAogCS8qIFdlIG5lZWQgYSBwcm9wZXIgQ1NVTSBiZWZvcmUgd2Ugc3RhcnQgKHMuIE9w ZW5CU0QgaXBfb3V0cHV0KSAqLwotCWlmICgoKm0pLT5tX3BrdGhkci5jc3VtX2ZsYWdzICYgQ1NV TV9ERUxBWV9EQVRBKSB7Ci0jaWZkZWYgSU5FVAotCQkvKiBYWFgtQlogY29weSZwYXN0ZSBlcnJv ciBmcm9tIHIxMjYyNjE/ICovCi0JCWluX2RlbGF5ZWRfY2tzdW0oKm0pOwotI2VuZGlmCi0JCSgq bSktPm1fcGt0aGRyLmNzdW1fZmxhZ3MgJj0gfkNTVU1fREVMQVlfREFUQTsKKwlpZiAoKCptKS0+ bV9wa3RoZHIuY3N1bV9mbGFncyAmIENTVU1fREVMQVlfREFUQV9JUFY2KSB7CisJCWluNl9kZWxh eWVkX2Nrc3VtKCptLCAoKm0pLT5tX3BrdGhkci5sZW4gLSBzaXplb2Yoc3RydWN0IGlwNl9oZHIp LCBzaXplb2Yoc3RydWN0IGlwNl9oZHIpKTsKKwkJKCptKS0+bV9wa3RoZHIuY3N1bV9mbGFncyAm PSB+Q1NVTV9ERUxBWV9EQVRBX0lQVjY7CiAJfQogCUNVUlZORVRfU0VUKGlmcC0+aWZfdm5ldCk7 CiAJY2hrID0gcGZfdGVzdDYoUEZfT1VULCBpZnAsIG0sIGlucCk7Cg== --001a113817fcc0512c0507d054a5--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPBZQG3GgS72wpTscxcQPA5pNSCimpFwquGC=4UOwY4tVyiQSA>