Date: Wed, 17 Mar 2010 20:30:37 +0000 (UTC) From: Gavin Atkinson <gavin@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sbin/growfs growfs.c Message-ID: <201003172030.o2HKUx7Z076206@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
gavin 2010-03-17 20:30:37 UTC
FreeBSD src repository
Modified files: (Branch: RELENG_7)
sbin/growfs growfs.c
Log:
SVN rev 205260 on 2010-03-17 20:30:37Z by gavin
Merge r201401 from head:
Remove dead code. This section of code is only run in the
(sblock.fs_magic == FS_UFS1_MAGIC) case, so the check within the
loop is redundant.
Merge 203835 from head:
When growing a UFS1 filesystem, we need to initialise all inodes in any new
cylinder groups that are created. When the filesystem is first created,
newfs always initialises the first two blocks of inodes, and then in the
UFS1 case will also initialise the remaining inode blocks. The changes in
growfs.c 1.23 broke the initialisation of all inodes, seemingly based on
this implementation detail in newfs(8). The result was that instead of
initialising all inodes, we would actually end up initialising all but the
first two blocks of inodes. If the filesystem was grown into empty
(all-zeros) space then the resulting filesystem was fine, however when
grown onto non-zeroed space the filesystem produced would appear to have
massive corruption on the first fsck after growing.
A test case for this problem can be found in the PR audit trail.
Fix this by once again initialising all inodes in the UFS1 case.
PR: bin/115174
Submitted by: "Nate Eldredge" <nge cs.hmc.edu>
Reviewed by: mjacob
Revision Changes Path
1.25.2.3 +6 -14 src/sbin/growfs/growfs.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201003172030.o2HKUx7Z076206>