Date: Sat, 22 Aug 2009 22:53:00 -0700 From: Juli Mallett <jmallett@FreeBSD.org> To: Doug Barton <dougb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r196435 - head/sys/conf Message-ID: <eaa228be0908222253x2d0c06ffm1ae015b2d1112491@mail.gmail.com> In-Reply-To: <200908230545.n7N5jcpZ047952@svn.freebsd.org> References: <200908230545.n7N5jcpZ047952@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 22, 2009 at 22:45, Doug Barton<dougb@freebsd.org> wrote: > Author: dougb > Date: Sun Aug 23 05:45:38 2009 > New Revision: 196435 > URL: http://svn.freebsd.org/changeset/base/196435 > > Log: > =A0The svnversion string is only relevant when newvers.sh is called > =A0during the kernel build process, the other places that call the script > =A0do not make use of that information. So restrict execution of the > =A0svnversion-related code to the kernel build context. This seems to assume that the kernel is always checked out in a directory called 'sys', is that right? That isn't always true in my experience, and I have a bad habit of keeping multiple kernel trees checked out named things like 'sys-head', etc. I could be misreading the code, which gave only constructs I'm not very familiar with for determining whether it's being used for a kernel build. Is it harmful to include the svnversion stuff for other newvers.sh users? Could they just set an environment variable to indicate they want it excluded? Or could you check the environment for kernel build-related variables? Or even set a variable when running newvers.sh for the kernel to explicitly request svnversion inclusion? Juli.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?eaa228be0908222253x2d0c06ffm1ae015b2d1112491>