Date: Sat, 30 Jul 2005 23:30:05 -0700 From: Nate Lawson <nate@root.org> To: Colin Percival <cperciva@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/cpufreq est.c Message-ID: <42EC6FED.1060307@root.org> In-Reply-To: <20050731015716.16A2C16A440@hub.freebsd.org> References: <20050731015716.16A2C16A440@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Colin Percival wrote:
> cperciva 2005-07-31 01:57:05 UTC
>
> FreeBSD src repository
>
> Modified files:
> sys/i386/cpufreq est.c
> Log:
> Remove the instruction to "contact the maintainer" for unrecognized
> CPUs. Intel refuses to give me the information I need, and getting
> more emails about this doesn't help.
>
> Revision Changes Path
> 1.8 +1 -3 src/sys/i386/cpufreq/est.c
>
>
> Index: src/sys/i386/cpufreq/est.c
> diff -u src/sys/i386/cpufreq/est.c:1.7 src/sys/i386/cpufreq/est.c:1.8
> --- src/sys/i386/cpufreq/est.c:1.7 Sun Apr 10 19:57:47 2005
> +++ src/sys/i386/cpufreq/est.c Sun Jul 31 01:57:05 2005
> @@ -705,9 +705,7 @@
> if (error) {
> printf(
> "est: CPU supports Enhanced Speedstep, but is not recognized.\n"
> - "est: Please update driver or contact the maintainer.\n"
> - "est: cpu_vendor %s, msr %0jx, bus_clk, %x\n",
> - cpu_vendor, msr, INTEL_BUS_CLK);
> + );
> return (ENXIO);
> }
I would prefer we still print the MSR and cpu_vendor info, even if you
remove the "contact maintainer" part. Also, most systems based on newer
Pentium-M export the control info via acpi_perf so if acpi is active, we
use those settings for est.
--
Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?42EC6FED.1060307>