Date: Fri, 4 Dec 2015 19:03:11 +0100 From: Hans Petter Selasky <hps@selasky.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r291699 - in head/sys: modules/mlxen ofed/drivers/net/mlx4 Message-ID: <5661D55F.4050902@selasky.org> In-Reply-To: <20151204175737.GA2202@kib.kiev.ua> References: <201512031456.tB3EuHVs030967@repo.freebsd.org> <20151204175737.GA2202@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/04/15 18:57, Konstantin Belousov wrote: > On Thu, Dec 03, 2015 at 02:56:17PM +0000, Hans Petter Selasky wrote: >> Author: hselasky >> Date: Thu Dec 3 14:56:17 2015 >> New Revision: 291699 >> URL: https://svnweb.freebsd.org/changeset/base/291699 >> >> Log: >> Convert the mlxen driver to use the BUSDMA(9) APIs instead of >> vtophys() when loading mbufs for transmission and reception. While at >> it all pointer arithmetic and cast qualifier issues were fixed, mostly >> related to transmission and reception. >> >> MFC after: 1 week >> Sponsored by: Mellanox Technologies >> Differential Revision: https://reviews.freebsd.org/D4284 >> >> Modified: >> head/sys/modules/mlxen/Makefile >> head/sys/ofed/drivers/net/mlx4/en_netdev.c >> head/sys/ofed/drivers/net/mlx4/en_rx.c >> head/sys/ofed/drivers/net/mlx4/en_tx.c >> head/sys/ofed/drivers/net/mlx4/mlx4_en.h >> >> Modified: head/sys/modules/mlxen/Makefile >> ============================================================================== >> --- head/sys/modules/mlxen/Makefile Thu Dec 3 14:38:55 2015 (r291698) >> +++ head/sys/modules/mlxen/Makefile Thu Dec 3 14:56:17 2015 (r291699) >> @@ -11,5 +11,3 @@ CFLAGS+= -I${.CURDIR}/../../ofed/include >> CFLAGS+= -I${.CURDIR}/../../compat/linuxkpi/common/include >> >> .include <bsd.kmod.mk> >> - >> -CFLAGS+= -Wno-cast-qual -Wno-pointer-arith > > I did not checked to definitely blame this commit, but I do get the > following error from the i386 LINT build: > > In file included from /scratch/tmp/kib/src/sys/modules/mlxen/../../ofed/drivers/ > net/mlx4/en_cq.c:34: > In file included from /scratch/tmp/kib/src/sys/modules/mlxen/../../ofed/include/ > linux/mlx4/cq.h:39: > /scratch/tmp/kib/src/sys/modules/mlxen/../../ofed/include/linux/mlx4/doorbell.h: > 80:42: error: arithmetic on a pointer to void is a GNU extension [-Werror,-Wpoin > ter-arith] > __raw_writel((__force u32) val[1], dest + 4); > ~~~~ ^ I'll check it out. --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5661D55F.4050902>