Date: Sun, 30 Jul 2017 20:25:19 -0700 From: Xin Li <delphij@delphij.net> To: Cy Schubert <cy@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Cc: d@delphij.net Subject: Re: svn commit: r321605 - head/contrib/ipfilter Message-ID: <59e80a44-d9de-5081-9eda-f068188b843f@delphij.net> In-Reply-To: <201707270626.v6R6QFpx016943@repo.freebsd.org> References: <201707270626.v6R6QFpx016943@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qkHf0G7WFcstcsFV7l4rWHvsuGQw2vRUe Content-Type: multipart/mixed; boundary="Jr1WPDWc9v4DdGMW1MpMm9tsIXBjADiqo"; protected-headers="v1" From: Xin Li <delphij@delphij.net> To: Cy Schubert <cy@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Cc: d@delphij.net Message-ID: <59e80a44-d9de-5081-9eda-f068188b843f@delphij.net> Subject: Re: svn commit: r321605 - head/contrib/ipfilter References: <201707270626.v6R6QFpx016943@repo.freebsd.org> In-Reply-To: <201707270626.v6R6QFpx016943@repo.freebsd.org> --Jr1WPDWc9v4DdGMW1MpMm9tsIXBjADiqo Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 7/26/17 23:26, Cy Schubert wrote: > Author: cy > Date: Thu Jul 27 06:26:15 2017 > New Revision: 321605 > URL: https://svnweb.freebsd.org/changeset/base/321605 >=20 > Log: > As in r315225, discard 3072 bytes of RC4 bytestream instead of 1024. > =20 > PR: 217920 > Submitted by: codarren@hackers.mu > Reviewed by: emaste, cem > Approved by: so (implicit, in r315225) Why ipfilter is using its own pseudo random number generator? Please remove them altogether and use the system PRNG instead. Cheers, --Jr1WPDWc9v4DdGMW1MpMm9tsIXBjADiqo-- --qkHf0G7WFcstcsFV7l4rWHvsuGQw2vRUe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJZfqMiAAoJEJW2GBstM+nsjK4P/161Peu4RfRmB8f0r+7CdWlG Dxcbrtr5pf+4TeKtPPIOv9QobeVPCxcCN2Ec3Pb/+LBjy3f/XrJYzzS0yAWz6gkr 2TB67Kuvp9wTCLZcyxu8fB10L4lT3cNOrwQ2Xr8FjJdJJXrPp6Dol3P5TGHdbpD4 K0F3wOw7ZNjWH6RmhKJXEFSkzX4VFtKONMItZlCtgqubObvWEbpUvsoC95hfs8er IIAlPNh48LxtTrEpyRDu2hqd/XTx52Rpcut1jfRo5rvaKAfZl2YGalnYX0NllFjo P1wpmI2ZJSMxfKaopeFLjwac9ri1IKicJaahGryU1r82YdMDrcDmoMJ7Bu8JsZoC NBzVc9mFmiv11MdyIUUbPsnVWXzhaDjkXedPuRSjWriODk2JzQf5t3NIS1kEyU8I lsCU16CWndH4+l7Kdg3G5BGFGCpM1/ubYobiJObUjrahwE2TGNrytu49ESm5eUdy LVbOwoq1NWg+M6nGLnPyZUEz0emorXbmebVzGFyl7NX6cIh31yNXoupvR+O9Gm/L jQmD9Mhfnb5Vi/N2KEl2Io4udVMOX84/vqALWN+09YgretG3MY4V1QywBbA8ZZJk 8bpEVsTrBJNFpZq8rF08t5O7jYs9AfzZ5qWEehBIus1AhpyVz/kSj+E9Bc7FbYRG lgFwudjhcxnLZqk+vBXh =B0Ry -----END PGP SIGNATURE----- --qkHf0G7WFcstcsFV7l4rWHvsuGQw2vRUe--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?59e80a44-d9de-5081-9eda-f068188b843f>