Date: Tue, 06 Oct 2015 11:26:36 -0700 From: John Baldwin <jhb@freebsd.org> To: Garrett Cooper <ngie@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r288907 - head/bin/ls/tests Message-ID: <2474554.zI8qz6W2Yp@ralph.baldwin.cx> In-Reply-To: <201510060100.t9610CXc077196@repo.freebsd.org> References: <201510060100.t9610CXc077196@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, October 06, 2015 01:00:12 AM Garrett Cooper wrote: > Author: ngie > Date: Tue Oct 6 01:00:12 2015 > New Revision: 288907 > URL: https://svnweb.freebsd.org/changeset/base/288907 > > Log: > Call sync consistently using atf_check > > Remove superfluous sync's You should not need to call sync() to see the results of earlier namespace changes (file create, rename, delete, etc.), even for NFS when looking on the same client that made the namespace change. Are you doing this to force mtime updates? You should not need sync() for that on UFS (ufs_getattr() forces any pending lazy timestamp updates). You would for NFS (not sure about ZFS). Whatever the reason for the syncs, I think it warrants a comment. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2474554.zI8qz6W2Yp>