Date: Thu, 1 Jun 2006 01:06:44 +0300 (EEST) From: Dmitry Pryanishnikov <dmitry@atlantis.dp.ua> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Howard Leadmon <howard@leadmon.net>, 'Rong-en Fan' <grafan@gmail.com>, freebsd-stable@freebsd.org, Kris Kennaway <kris@obsecurity.org> Subject: Re: [patch, try 1] Re: Trouble with NFSd under 6.1-Stable, any ideas? Message-ID: <20060530223342.G2710@atlantis.atlantis.dp.ua> In-Reply-To: <20060525145809.GP54541@deviant.kiev.zoral.com.ua> References: <001401c67f56$b02975e0$071872cf@Leadmon.local> <003001c67fae$27a88370$071872cf@Leadmon.local> <20060525051926.GB97976@xor.obsecurity.org> <20060525145809.GP54541@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello!
On Thu, 25 May 2006, Konstantin Belousov wrote:
> KASSERT(!(debug_mpsafenet == 1 && mtx_owned(&Giant)),
> ("nfssvc_nfsd(): debug.mpsafenet=1 && Giant"));
>
> from nfsserver/nfs_syscalls.c, line 570.
>
> As I understand the problem, kern/vfs_lookup.c:lookup() could
> aquire additional locks on Giant, indicating this by GIANTHELD
> flag in nd. All processing in nfsserver already goes with Giant held,
> so, I just dropped that excessive locks after return from lookup.
> System with patch applied survived smoke test (client did
> du on mounted dir, patch was generated from exported fs, etc.).
> nfsd eats no more than 25% of CPU (with INVARIANTS).
>
> Please, users who reported the problem and willing to help,
> try the patch (generated against STABLE) and give the feedback.
Thank you very much. Your patch actually fixes "nfssvc_nfsd():
debug.mpsafenet=1 && Giant" panic during NFS mount of server's "/usr".
Oddly enough, NFS mount of server's "/" doesn't panic the server.
My kernel config contains "options QUOTA", however quotas are not enabled.
Please commit the fix, IMHO long-term breakage of such a basic functionality
(NFS server + quotas) in -STABLE branch isn't a Good Thing (TM).
Sincerely, Dmitry
--
Atlantis ISP, System Administrator
e-mail: dmitry@atlantis.dp.ua
nic-hdl: LYNX-RIPE
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060530223342.G2710>