Date: Mon, 27 Jun 2005 16:51:52 -0400 From: John Baldwin <jhb@FreeBSD.org> To: freebsd-current@freebsd.org Cc: Martin Cracauer <cracauer@cons.org>, Eric Anholt <eta@lclark.edu>, Adam K Kirchhoff <adamk@voicenet.com>, Warner Losh <imp@bsdimp.com> Subject: Re: 6.0-current panic: loading radeon module Message-ID: <200506271651.54116.jhb@FreeBSD.org> In-Reply-To: <1119816026.3817.20.camel@leguin> References: <20050617173008.A11142@cons.org> <20050624195906.A5702@cons.org> <1119816026.3817.20.camel@leguin>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday 26 June 2005 04:00 pm, Eric Anholt wrote: > On Fri, 2005-06-24 at 19:59 -0400, Martin Cracauer wrote: > > > I'd forgotten about this thread. I've got a proposed fix for this at: > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/80718 > > > > I get the same panic and backtrace with that patch (on a 32 MB moobile > > Radeon 7500). > > > > I will annotate the sourcecode now to verify (or not) the NULLs in the > > arguments for the bus argument. > > OK, one more try, for everyone who's been having hangs/reboots on X > startup since April. Attached is a patch that will hopefully kill the > problem off. It would probably be best to use bus_alloc_resource() without RF_ACTIVE set as otherwise you'll get a base address of 0 using the bus_get_resource() method if the BAR hasn't been mapped yet (e.g., this isn't a boot display device). Also, please use 'rid = PCIR_BAR(resource)' rather than 'rid = resource * 4 + 0x10' as that's probably a lot clearer way of saying that you are mapping BAR 'resource'. You can also still alloc the framebuffer resource in your last hunk, just don't set RF_ACTIVE for the framebuffer but do set it for the mmio registers. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200506271651.54116.jhb>