Date: Fri, 13 Feb 2004 15:39:53 -0800 (PST) From: Julian Elischer <julian@elischer.org> To: Scott Long <scottl@freebsd.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/bfe if_bfe.c if_bfereg.h Message-ID: <Pine.BSF.4.21.0402131522240.10794-100000@InterJet.elischer.org> In-Reply-To: <20040213152836.U25703@pooker.samsco.home>
next in thread | previous in thread | raw e-mail | index | archive | help
Oh I'm standing by it.. This version is working for me so far but I have heard rumours that the -current driver has an occasional 'hang'. There is another rumour that this driver has inherritted the problem, but I have never seen it.. The driver is not built by default and the module will not build unless you specifically edit out the line that tells you there may be problems.. so I don't see how this affects anyone, but it DOES give people a way of trying it out.. I will be supporting it because we (Vicor) plan on using this driver in production on 4.x. So I need to have it reliable. My main test machine is out of commision for a couple of days but I found a laptop (Dell 5150) with the same chip and that allowed me to confirm that this now works.. It's been in use on that machine without problems for a short while and I'll be backing it up with the debug machine (with full gdb/ddb support) as soon as it comes back from being repaired. When I have it back I will be looking at possibly merging in some fixes from Dragonfly (via -current). > On Fri, 13 Feb 2004, Julian Elischer wrote: > > julian 2004/02/13 13:36:34 PST > > > > FreeBSD src repository > > > > Modified files: (Branch: RELENG_4) > > sys/dev/bfe if_bfe.c if_bfereg.h > > Log: > > Upgrade to the version of the MFC by Edwin Groothuis. > > This seems to work but I have heard of hangs... > > > > Revision Changes Path > > 1.4.4.3 +101 -91 src/sys/dev/bfe/if_bfe.c > > 1.1.4.3 +12 -0 src/sys/dev/bfe/if_bfereg.h > > > > > > Julian, > > Are you willing to stand by this commit? Your comment implies that you > don't know if it works or not. If so, then RELENG_4 is certainly not the > place for this. Mr. Groothuis might have done a fine job with this, but > unless you as a committer and senior member of this project are willing > to actually review, test, and validate it, then it needs to be backed out > and revisited at a later date. > > Scott >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0402131522240.10794-100000>