Date: Tue, 3 Mar 2026 05:22:42 -0700 From: Warner Losh <imp@bsdimp.com> To: Brooks Davis <brooks@freebsd.org> Cc: Enji Cooper <ngie@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: 912864912b71 - main - Run `make obj` before running `make test-includes` Message-ID: <CANCZdfrfKgMm7N9nE-DNkWzr9=vqmaKzd%2BRrvYeg_7OQ=aSL4Q@mail.gmail.com> In-Reply-To: <aabRjaEUESOKOFZj@spindle.one-eyed-alien.net> References: <69a678f3.3f811.148b0d7d@gitrepo.freebsd.org> <CANCZdfpdrkwj8RZtKubzg4feo5i61ivfwRSgwZM7U0k_9V%2B=pQ@mail.gmail.com> <aabRjaEUESOKOFZj@spindle.one-eyed-alien.net>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Tue, Mar 3, 2026 at 5:18 AM Brooks Davis <brooks@freebsd.org> wrote: > On Tue, Mar 03, 2026 at 04:25:48AM -0700, Warner Losh wrote: > > On Mon, Mar 2, 2026, 11:00???PM Enji Cooper <ngie@freebsd.org> wrote: > > > > > The branch main has been updated by ngie: > > > > > > URL: > > > > https://cgit.FreeBSD.org/src/commit/?id=912864912b71951f9a636190b1dba80528f588eb > > > > > > commit 912864912b71951f9a636190b1dba80528f588eb > > > Author: Enji Cooper <ngie@FreeBSD.org> > > > AuthorDate: 2026-03-03 05:59:50 +0000 > > > Commit: Enji Cooper <ngie@FreeBSD.org> > > > CommitDate: 2026-03-03 05:59:56 +0000 > > > > > > Run `make obj` before running `make test-includes` > > > > > > Before this change, `make test-includes` (run as part of > buildworld) > > > would place test files in the current directory, which would > clutter up > > > git clones. Run `make obj` beforehand to ensure that the files are > put > > > in `${.OBJDIR}` instead of `${.CURDIR}`. This helps cut down on the > > > noise significantly when running commands like `git status`. > > > > > > > I've never seen this happen. .OBJDIR is created automatically for me > always > > for the last 5 years... I run buildworld all the time. Can you explain > when > > / how it happens more specifically or back out the change? > > The commit message is unintentionally misleading and incomplete. I hit > the problem a week or so ago when fixing gcc12 builds and lacked the > time to follow up. test-includes is fine as part of buildworld, but > when run directly from src does fill tools/build/test-includes with .c > files if you blow away the objdir (which seems to the the only reliably > way to cause test-includes to retest some more complex cases.) > Ah! That should have been in the commit message as the edge case that provoked this. That's a decent explanation, though there's other bits of buildworld that will also cause problems if you do them in isolation and not part of buildworld. This one, though, is important enough to make an exception for, I think. It's one that's most likely to be used in isolation. Warner [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Tue, Mar 3, 2026 at 5:18 AM Brooks Davis <<a href="mailto:brooks@freebsd.org">brooks@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Tue, Mar 03, 2026 at 04:25:48AM -0700, Warner Losh wrote:<br> > On Mon, Mar 2, 2026, 11:00???PM Enji Cooper <<a href="mailto:ngie@freebsd.org" target="_blank">ngie@freebsd.org</a>> wrote:<br> > <br> > > The branch main has been updated by ngie:<br> > ><br> > > URL:<br> > > <a href="https://cgit.FreeBSD.org/src/commit/?id=912864912b71951f9a636190b1dba80528f588eb" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=912864912b71951f9a636190b1dba80528f588eb</a><br>; > ><br> > > commit 912864912b71951f9a636190b1dba80528f588eb<br> > > Author: Enji Cooper <ngie@FreeBSD.org><br> > > AuthorDate: 2026-03-03 05:59:50 +0000<br> > > Commit: Enji Cooper <ngie@FreeBSD.org><br> > > CommitDate: 2026-03-03 05:59:56 +0000<br> > ><br> > > Run `make obj` before running `make test-includes`<br> > ><br> > > Before this change, `make test-includes` (run as part of buildworld)<br> > > would place test files in the current directory, which would clutter up<br> > > git clones. Run `make obj` beforehand to ensure that the files are put<br> > > in `${.OBJDIR}` instead of `${.CURDIR}`. This helps cut down on the<br> > > noise significantly when running commands like `git status`.<br> > ><br> > <br> > I've never seen this happen. .OBJDIR is created automatically for me always<br> > for the last 5 years... I run buildworld all the time. Can you explain when<br> > / how it happens more specifically or back out the change?<br> <br> The commit message is unintentionally misleading and incomplete. I hit<br> the problem a week or so ago when fixing gcc12 builds and lacked the<br> time to follow up. test-includes is fine as part of buildworld, but<br> when run directly from src does fill tools/build/test-includes with .c<br> files if you blow away the objdir (which seems to the the only reliably<br> way to cause test-includes to retest some more complex cases.)<br></blockquote><div><br></div><div>Ah! That should have been in the commit message as the edge case</div><div>that provoked this. That's a decent explanation, though there's other</div><div>bits of buildworld that will also cause problems if you do them in isolation</div><div>and not part of buildworld. This one, though, is important enough to make</div><div>an exception for, I think. It's one that's most likely to be used in isolation.</div><div><br></div><div>Warner </div></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrfKgMm7N9nE-DNkWzr9=vqmaKzd%2BRrvYeg_7OQ=aSL4Q>