Date: Tue, 23 Jun 2009 13:26:39 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: freebsd-current@FreeBSD.org Cc: Roman Divacky <rdivacky@freebsd.org> Subject: Re: [PATCH]: if (cond); foo() in firewire Message-ID: <200906231326.42555.jkim@FreeBSD.org> In-Reply-To: <20090621082022.GA88526@freebsd.org> References: <20090621082022.GA88526@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday 21 June 2009 04:20 am, Roman Divacky wrote:
> hi
>
> is this patch correct? may I commit it?
>
> Index: ../../../dev/firewire/fwdev.c
> ===================================================================
> --- ../../../dev/firewire/fwdev.c (revision 194573)
> +++ ../../../dev/firewire/fwdev.c (working copy)
> @@ -443,7 +443,7 @@
> xfer->send.pay_len = uio->uio_resid;
> if (uio->uio_resid > 0) {
> if ((err = uiomove((caddr_t)&xfer->send.payload[0],
> - uio->uio_resid, uio)));
> + uio->uio_resid, uio)))
> goto out;
> }
>
>
> another bug found by the "useless warnings in clang" ;)
Just for the record, it seems this bug was fixed in NetBSD long ago:
http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/dev/ieee1394/fwdev.c.diff?r1=1.3&r2=1.4
I hope it boosts your confidence level a bit. :-)
Jung-uk Kim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200906231326.42555.jkim>