Date: Fri, 8 Jan 2021 02:49:31 +0300 From: Vladimir Kondratyev <vladimir@kondratyev.su> To: Ravi Pokala <rpokala@freebsd.org>, Jessica Clarke <jrtc27@freebsd.org>, Vladimir Kondratyev <wulf@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: 92cf602e3809 - main - Copy strcasestr.c from libc to libkern. Message-ID: <a527f34b-2fbe-7729-e029-a820d0545910@kondratyev.su> In-Reply-To: <3EA011C9-2EEC-4693-B36D-69E74DF8473C@panasas.com> References: <202101072320.107NKpMS063374@gitrepo.freebsd.org> <F0A2E7AD-499B-4CA5-AF6B-1C7F9F5B49BC@freebsd.org> <7a7fa0fb-51c2-1b14-6d37-2c400f69d7dd@kondratyev.su> <3EA011C9-2EEC-4693-B36D-69E74DF8473C@panasas.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 08.01.2021 02:41, Ravi Pokala wrote: > -----Original Message----- > From: <owner-src-committers@freebsd.org> on behalf of Vladimir Kondratyev <vladimir@kondratyev.su> > Date: 2021-01-07, Thursday at 15:33 > To: Jessica Clarke <jrtc27@freebsd.org>, Vladimir Kondratyev <wulf@FreeBSD.org> > Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> > Subject: Re: git: 92cf602e3809 - main - Copy strcasestr.c from libc to libkern. > > On 08.01.2021 02:27, Jessica Clarke wrote: > > On 7 Jan 2021, at 23:20, Vladimir Kondratyev <wulf@FreeBSD.org> wrote: > >> +#include <ctype.h> > >> +#include <string.h> > >> +#include "xlocale_private.h" > >> + > >> +/* > >> + * Find the first occurrence of find in s, ignore case. > >> + */ > >> +char * > >> +strcasestr_l(const char *s, const char *find, locale_t locale) > > > > Locales in the kernel? This feels wrong. > > > > Jess > > > > strcasestr.c was copied from userland unmodified just to allow > "git log --follow" to work. Next commit removed locale support from this > file and connected it to build. > > Unfortunately, about two-dozen commit messages from you arrived at the same time, and some were out of order; without incrementing change numbers in the subject line, figuring out the actual ordering is non-trivial. :-p > > -Ravi (rpokala@) > I hope, commit hook will be improved some day. Pushing of two-dozen commits one by one is too boring.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a527f34b-2fbe-7729-e029-a820d0545910>